[LIBCLOUD-672] [LIBCLOUD-673] Create volume from snapshot on EC2 and OS #467
Conversation
LIBCLOUD-672 #close
LIBCLOUD-673 #close
The base driver defines a signature that is not used by any of the drivers implementing `create_volume`. 1. `gandi` does not use the snapshot parameter. 1. `gce` uses the parameter, but accepts either a string or an object or None. 1. `ibm` does not use the snapshot parameter. 1. `opennebula` does not use the snapshot parameter. 1. `profitbricks` breaks the contract entirely. In this PR both `ec2` and `openstack` implement the signature like this. This matches `gce`, so all drivers using the snapshot functionality act like this new signature.
|
@Kami, what do you think? |
allardhoeve
changed the title
|
Sorry for the delay, very busy with day job recently, will look into it... |
| :param snapshot: Name of snapshot from which to create the new | ||
| volume. (optional) | ||
| :type snapshot: ``str`` | ||
| :param snapshot: Snapshot from which to create the new |
There was a problem hiding this comment.
This is a breaking change - can you please document it in docs/upgrade_notes.rst?
|
Besides the upgrade notes entry, the change looks good to me. |
|
I notice there have been no upgrade notes since 1.16.0? So no notes for 1.17? |
|
Yeah, there were no special notes for 0.17. Just add a section for "in development" now. |
|
Will document, but this is actually not a breaking change: The base driver defines a signature that is not used by any of the drivers implementing
In this PR both |
|
Documented. |
|
@Kami, done |
|
Merged, thanks. |
Closes apache#467 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Both platforms support creating a volume from snapshots but do not implement it.
Please see individual commit messages for reasoning on why the changes are as they are.