Added volume type to create_volume in openstack #553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fx. to allow the choose between SATA and SSD
| @@ -164,7 +164,8 @@ def list_nodes(self, ex_all_tenants=False): | |||
| return self._to_nodes( | |||
| self.connection.request('/servers/detail', params=params).object) | |||
|
|
|||
| def create_volume(self, size, name, location=None, snapshot=None): | |||
| def create_volume(self, size, name, location=None, snapshot=None, | |||
| volume_type=None): | |||
There was a problem hiding this comment.
Sorry for the delay.
This is an extension argument (not part of the standard API) so it should be prefixed with ex_ - ex_volume_type.
|
Made the argument name change, squashed the commits and merged changes into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fx. to allow to choose between SATA and SSD. When None given, the default is used.