LIBCLOUD-830 Adding S3 support for cn-north-1 #827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! That's actually the old approach which has been mostly removed in v1.0.0 (we moved away from class per region to "region" constructor argument approach), but S3 is one of the drivers which still needs to be updated... I will go ahead and merge this for now, but hopefully we can also update S3 driver soon and move it to the new model (then we can get rid of this code). |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add S3 support for AWS China (cn-north-1)
Description
This PR adds S3 support for AWS China (cn-north-1)
Status
Checklist (tick everything that applies)