Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-952] Use disk size and storage tier also when creating node from template #1124

Conversation

mlackman
Copy link

@mlackman mlackman commented Oct 6, 2017

Add disk size and storage tier

Description

Added missing storage_tier and disk size to the request body for creating node. Storage_tier has meaningful default value when not provided.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-io
Copy link

Codecov Report

Merging #1124 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           trunk   #1124      +/-   ##
========================================
+ Coverage   85.4%   85.4%   +<.01%     
========================================
  Files        346     346              
  Lines      66200   66218      +18     
  Branches    5892    5892              
========================================
+ Hits       56535   56553      +18     
  Misses      7267    7267              
  Partials    2398    2398
Impacted Files Coverage Δ
libcloud/test/compute/test_upcloud.py 92.19% <ø> (ø) ⬆️
libcloud/common/upcloud.py 91.01% <100%> (+0.53%) ⬆️
libcloud/test/common/test_upcloud.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fef3b5...e7e0869. Read the comment docs.

@asfgit asfgit closed this in 63eeacd Oct 6, 2017
asfgit pushed a commit that referenced this pull request Oct 6, 2017
@pquentin
Copy link
Contributor

pquentin commented Oct 6, 2017

Thank you! Merged in trunk. Please close LIBCLOUD-952. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants