[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter #1252

kiniou · 2018-11-10T13:16:29Z

Enhance digitalocean dns driver with `ttl` parameter

Description

DigitalOcean provides a parameter to update dns records with ttl but the current driver's code actually doesn't support it.

For reference:

Status

ready for review

Checklist (tick everything that applies)

Code linting (required, can be done after the PR checks)
Documentation
Tests
ICLA (required for bigger changes)

…reserving the drs and tests directories

…etrieval by process_xml

…drivers/nttcis.py. Started testing delete

…devops/libcloud into dynamic

…d tests

…r get single cg

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

…ML from snapshots, added integrations test, and a fixture for unit tests

…ses a decorator to list/filter consistency groups

…rnal.

…ltering create times

codecov-io · 2018-11-10T13:22:18Z

Codecov Report

Merging #1252 into trunk will increase coverage by 0.24%.
The diff coverage is 83.83%.

@@            Coverage Diff             @@
##            trunk    #1252      +/-   ##
==========================================
+ Coverage   85.74%   85.98%   +0.24%     
==========================================
  Files         356      359       +3     
  Lines       72369    73809    +1440     
  Branches     6537     6698     +161     
==========================================
+ Hits        62053    63466    +1413     
+ Misses       7715     7666      -49     
- Partials     2601     2677      +76

Impacted Files	Coverage Δ
libcloud/compute/types.py	`100% <ø> (ø)`	⬆️
libcloud/compute/drivers/voxel.py	`87.3% <ø> (ø)`	⬆️
libcloud/container/drivers/dummy.py	`0% <ø> (ø)`	⬆️
libcloud/common/cloudstack.py	`86.59% <ø> (ø)`	⬆️
libcloud/common/digitalocean.py	`94.59% <ø> (ø)`	⬆️
libcloud/storage/drivers/s3.py	`89.08% <ø> (ø)`	⬆️
libcloud/compute/deployment.py	`97.22% <ø> (ø)`	⬆️
libcloud/dns/providers.py	`50% <ø> (ø)`	⬆️
libcloud/__init__.py	`71.42% <ø> (ø)`	⬆️
libcloud/common/azure_arm.py	`73.01% <ø> (ø)`	⬆️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d40806...c2399e4. Read the comment docs.

kiniou · 2018-11-10T13:27:06Z

Hi 👋

I was not sure if the ttl parameters should go directly in methods signature or in extra arguments.

There seems to be some inconsistence between some drivers (eg. powerdns) and documentation.

Just let me know if i need to do the switch 😉.

…ableSequence and Mapping based on python vesions in libcloud/common/nttcis; added code blocks for dynamic class creation from xml as opposed to pick and choose properties from xml in common/nttcis; firewall rules are dynamic

into feature_drs

…_subscription_includes_free_tier_resources

…thub.com/vdloo/libcloud into vdloo-fix-detach-volume-OpenStack_2_NodeDriver Resolves apache#1267

driver: update Exoscale info

on Travis with newer version of requests.

into trunk

It looks like the build fails on travis because of old setuptools.

Add a workaround for Python 3.7 build failure on Travis

into update_test_dependencies Try a workaround for failing py3.7 build.

Update test dependencies

…_fails_if_your_subscription_includes_free_tier_resources' of https://github.com/aki-k/libcloud into LIBCLOUD-1040_CloudSigma_provider_ex_list_subscriptions_fails_if_your_subscription_includes_free_tier_resources

start_time and / or end_time attributes.

…ovider_ex_list_subscriptions_fails_if_your_subscription_includes_free_tier_resources LIBCLOUD-1040_CloudSigma_provider_ex_list_subscriptions_fails_if_your…

…rror fix comment ProviderError dereived -> derived

Kami · 2019-05-26T19:40:00Z

Re ttl in the extra attribute - it looks like a lot of the existing drivers support TTL attribute for records so I think it would be time to "promote" this attribute from extra to ttl argument in create / update record methods in the next major release.

For backward compatibility reasons we should still support ttl in extra, with ``ttl` having precedence over extra attribute.

…ttps://github.com/kiniou/libcloud into LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter

Kami · 2019-05-26T19:57:03Z

Sorry for the delay.

I made a small change (ec563f9) and merged changes into trunk. Thanks again for your contribution.

mitch and others added 23 commits October 4, 2018 07:56

Added new code for xml parsing to common/nttcis

067e93e

added file test_lib_list.py

fcd632a

Merge branch 'drs' into feature_drs hopefully get all changes while p…

15ce000

…reserving the drs and tests directories

Added abstract Driver class in drs/drivers/nttcis

adcf3bd

the drs driver does function

62d9eb6

merged with drs

14a69ee

removed dd prefix from region on tests files

a88fb2f

changed _to_nodes and _to_node and drivers/nttcis.py to handle node r…

81d5736

…etrieval by process_xml

Test failed DRS creation not supported between the selected data centers

10c4a31

moved create_consistency_group to drs/drivers/nttcis.py from compute/…

88daff6

…drivers/nttcis.py. Started testing delete

Merge branch 'feature_drs' of https://bitbucket.mcp-services.net/scm/…

82afeb4

…devops/libcloud into dynamic

can list cg groups

f8c0da6

added directories and started files for drs/test suite

c32aa10

added fixtures for drs ineligible error and listing cg's and complete…

0346c30

…d tests

commented out several classes in common/nttcis module, added tests fo…

62e0aaf

…r get single cg

driver: update Exoscale info

a7c1672

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

added listing snapshots, edited the XmlToDictConfig class to handle X…

3d3289d

…ML from snapshots, added integrations test, and a fixture for unit tests

added more tests to tests and test directory. nttcis module for drs u…

1935b5f

…ses a decorator to list/filter consistency groups

Added documentation for drs via sphinx and added tests for expand jou…

614b43d

…rnal.

added auto generated rst files to ../docs/drs/

9c76b41

added addtional tests and the functionality to choose snapshots by fi…

3e83d4b

…ltering create times

drs finished...need to run tox, pull latest and pull request

8ed60c7

add ttl parameters to digitalocean record operations

57a80f9

mitch added 5 commits November 13, 2018 11:28

Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/libcloud

805a272

into feature_drs

renamed file after testing .pylintrc.bak -> .pylintrc

99b7bda

removed indent from docstring of NttCisDRSDriver

2c5b5cf

removed more indents on libcloud/drs/drivers/nttcis.py

30d2af8

Aki Ketolainen and others added 23 commits March 29, 2019 15:56

LIBCLOUD-1040_CloudSigma_provider_ex_list_subscriptions_fails_if_your…

940d97d

…_subscription_includes_free_tier_resources

Merge branch 'fix-detach-volume-OpenStack_2_NodeDriver' of https://gi…

4e9403f

…thub.com/vdloo/libcloud into vdloo-fix-detach-volume-OpenStack_2_NodeDriver Resolves apache#1267

Add changelog entry.

b6b358f

Merge pull request apache#1251 from exoscale/fresher-exoscale

88041ef

driver: update Exoscale info

Update tox dependency on travis.

9b3dc41

Fix a bug with ECS tests using wrong hostname which caused tests to fail

8f0ad03

on Travis with newer version of requests.

Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/libcloud

c6dc9ac

into trunk

Update various test dependencies (flake8, pylint, astroid, tox).

090389b

Update pylint config so it works with new version of pylint.

1f84ca8

Add a workaround for false positives detected by new version of pylint.

c240a9d

Fix various lint issues detected by new version of flake8

d021a3a

Fix more false positives detected by new version of pylint.

d47f382

Fix more false positives.

a39ca91

Upgrade astroid dependency.

6028411

Add a workaround for Python 3.7 build failure.

2ac522b

It looks like the build fails on travis because of old setuptools.

Merge pull request apache#1289 from Kami/fix_build

f22ea3c

Add a workaround for Python 3.7 build failure on Travis

Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/libcloud

8c4187b

into update_test_dependencies Try a workaround for failing py3.7 build.

Merge pull request apache#1288 from Kami/update_test_dependencies

c4eba4f

Update test dependencies

Update CloudSigma driver to correctly handle subscription objects with

41fd964

start_time and / or end_time attributes.

Add changelog entry for it.

e5aff9e

Merge pull request apache#1284 from aki-k/LIBCLOUD-1040_CloudSigma_pr…

e854784

…ovider_ex_list_subscriptions_fails_if_your_subscription_includes_free_tier_resources LIBCLOUD-1040_CloudSigma_provider_ex_list_subscriptions_fails_if_your…

Merge pull request apache#1262 from vdloo/dereived-derived-provider-e…

91d266c

…rror fix comment ProviderError dereived -> derived

Kami approved these changes May 26, 2019

View reviewed changes

Kami added 3 commits May 26, 2019 21:42

Merge branch 'LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter' of h…

18bb84a

…ttps://github.com/kiniou/libcloud into LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter

Don't explode if "ttl" attribute is not present, update affected tests.

ec563f9

Add changelog entry.

c2399e4

Kami merged commit 064ad6c into apache:trunk May 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter #1252

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter #1252

kiniou commented Nov 10, 2018

codecov-io commented Nov 10, 2018 •

edited

kiniou commented Nov 10, 2018

Kami commented May 26, 2019

Kami commented May 26, 2019

[LIBCLOUD-1022] Enhance digitalocean dns driver with ttl parameter #1252

[LIBCLOUD-1022] Enhance digitalocean dns driver with ttl parameter #1252

Conversation

kiniou commented Nov 10, 2018

Enhance digitalocean dns driver with ttl parameter

Description

Status

Checklist (tick everything that applies)

codecov-io commented Nov 10, 2018 • edited

Codecov Report

kiniou commented Nov 10, 2018

Kami commented May 26, 2019

Kami commented May 26, 2019

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter #1252

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter #1252

Enhance digitalocean dns driver with `ttl` parameter

codecov-io commented Nov 10, 2018 •

edited