Promote start node and stop node methods to standard Libcloud compute API #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those methods are promoted to be part of the Libcloud standard compute API because they are currently implemented as extension methods by a lot of the existing compute drivers.
"ex_start_node" and "ex_stop_node" to implement "start_node" and "stop_node" methods.
Codecov Report
@@ Coverage Diff @@
## trunk #1375 +/- ##
==========================================
- Coverage 86.33% 86.32% -0.01%
==========================================
Files 372 372
Lines 76232 76318 +86
Branches 6979 6979
==========================================
+ Hits 65817 65885 +68
- Misses 7614 7633 +19
+ Partials 2801 2800 -1
Continue to review full report at Codecov.
|
|
Great idea! I skimmed through and it looks good to me @Kami. |
Eis-D-Z
pushed a commit
to Eis-D-Z/libcloud
that referenced
this pull request
Oct 14, 2020
Promote start node and stop node methods to standard Libcloud compute API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new
start_node(self, node)andstop_node(self, node)methods to the base computeNodeDriverclass.This means those two methods have been "promoted" and are now part of the standard Libcloud compute API.
Background, Reasoning
A big chunk of the existing compute drivers (18) already implemented this functionality as part of
ex_start_nodeandex_stop_nodemethod so it only makes sense to promote those methods to be part of the standard compute API.For backward compatibility reasons, existing extension methods are left in place and they continue to behave as they did in the previous releases. Those methods will be removed as part of a cleanup in a future major release.
TODO