Changes for v2.8.1 release #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lower case in the Google Storage driver when using Interoperability S3 API authentication method. This would cause 401 error to be returned when uploading an object which mime / content type contains mixed casing (e.g. application/vnd.ms-excel.sheet.macroEnabled.12). Resolves apache#1417.
…river, introducing this error where the literal string 'ex_userdata' was passed during create_node intead of the actual ex_userdata kwarg.
That error likely represents a file handler / iterator which doesn't support a seek operation (such as pipe) and in such scenario we simply want to ignore that error.
to the record.extra dictionary. Without it, export_to_bind_format() method doesn't work. Resolves apache#1428
LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE works correctly under Python 3.
handles pagination if there are more than 500 results either for all the aggregated zones or for a single zone when a zone if specified by the user using "ex_zone" argument. Previously only up to 500 nodes were returned.
rid of one level of indentation on a common code path.
is encrypted using AWS KMS encryption. In such scenarios, ETag header doesn't contain object data MD5 digest. See https://docs.aws.amazon.com/AmazonS3/latest/API/RESTCommonResponseHeaders.html and apache#1401 for details.
It appears they become obsolete and unused during requests migration.
c-w
approved these changes
Feb 29, 2020
Codecov Report
@@ Coverage Diff @@
## 2.8.x #1433 +/- ##
=========================================
+ Coverage 86.3% 86.34% +0.04%
=========================================
Files 372 372
Lines 76545 76667 +122
Branches 7009 7016 +7
=========================================
+ Hits 66062 66199 +137
+ Misses 7682 7669 -13
+ Partials 2801 2799 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cherry picks the following changes from trunk and soon to be v3.0.0 release into 2.8.x branch - https://github.com/apache/libcloud/pulls?q=is%3Apr+is%3Aclosed+label%3A%22potential+2.8.x+candidate%22.
v2.8.0 is a last major release before v3.0.0 which will be announced shortly (I plan to start a voting thread in the next couple of days) so I decided to cherry pick some bug fixes from trunk and include them in the v2.8.1 release.
You can think of v2.8.x branch of Libcloud as a LTS release which still supports Python 2.7. All the new features will land in future v3.x.x releases, but for a while we may also do some more releases in the v2.8.x series if a major bug or security issue is found.