Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1641: [EC2] Add missing "creation_date" NodeImage extra #1642

Merged
merged 1 commit into from Jan 28, 2022
Merged

fix #1641: [EC2] Add missing "creation_date" NodeImage extra #1642

merged 1 commit into from Jan 28, 2022

Conversation

mazerty
Copy link
Contributor

@mazerty mazerty commented Jan 10, 2022

[EC2] Add missing "creation_date" NodeImage extra

Description

Fixes #1641.
Also tested "live" with modified 3.4.1 code in a virtualenv and listing real images.

Status

  • done, ready for review

Checklist

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Copy link
Member

@Kami Kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #1642 (8be3308) into trunk (90971e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1642   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files         398      398           
  Lines       86709    86712    +3     
  Branches     9217     9217           
=======================================
+ Hits        72120    72123    +3     
  Misses      11453    11453           
  Partials     3136     3136           
Impacted Files Coverage Δ
libcloud/compute/drivers/ec2.py 75.49% <ø> (ø)
libcloud/test/compute/test_ec2.py 97.89% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90971e1...8be3308. Read the comment docs.

@asfgit asfgit merged commit 8be3308 into apache:trunk Jan 28, 2022
@mazerty mazerty deleted the ec2-image-creation-date branch January 29, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EC2] Add missing "creation_date" NodeImage extra
4 participants