New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a request is made to a CDN endpoint there is no internalURL to use,... #231

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@jobelenus
Contributor

jobelenus commented Jan 29, 2014

... we have to fall back to the publicURL. This was an oversight on my part with my first pull request --#229

And this is the fix

@asfgit asfgit closed this in 34c3df4 Jan 30, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 30, 2014

Member

Thanks for making those changes.

There were some lint issues which I have fixed and merged patch into trunk. Next time please run tox -e lint and make sure there are no lint issues.

Member

Kami commented Jan 30, 2014

Thanks for making those changes.

There were some lint issues which I have fixed and merged patch into trunk. Next time please run tox -e lint and make sure there are no lint issues.

@jobelenus

This comment has been minimized.

Show comment
Hide comment
@jobelenus

jobelenus Jan 30, 2014

Contributor

Ah thanks for that local command, I was always waiting for Travis to fail me :(

Contributor

jobelenus commented Jan 30, 2014

Ah thanks for that local command, I was always waiting for Travis to fail me :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment