when a request is made to a CDN endpoint there is no internalURL to use,... - #231
Closed
jobelenus wants to merge 2 commits into
Closed
when a request is made to a CDN endpoint there is no internalURL to use,...#231jobelenus wants to merge 2 commits into
jobelenus wants to merge 2 commits into
Conversation
…se, we have to fall back to the publicURL
Member
There was a problem hiding this comment.
Those attributes need better name.
On top of that, if they are upper case (constants) they should probably be stored on module level and not on class level.
Contributor
Author
There was a problem hiding this comment.
I was thinking about making them module level, but they only apply to the connection class.
Member
|
Thanks for making those changes. There were some lint issues which I have fixed and merged patch into trunk. Next time please run |
Contributor
Author
|
Ah thanks for that local command, I was always waiting for Travis to fail me :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... we have to fall back to the publicURL. This was an oversight on my part with my first pull request --#229
And this is the fix