-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenStack public ip addresses fix #235
Conversation
private_ips.append(ip) | ||
else: | ||
public_ips.append(ip) | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to catch a more specific exception.
@mgogoulos Bump^^ |
I did some changes and pushed the tests (they've already been in test_list_nodes inside). |
@mgogoulos Yeah, tests shouldn't rely on some arbitrary ordering, but in this case it seems like the order should always be the same? Or am I missing something? |
@mgogoulos In any case, I'm also fine with using |
Fixed the tests, ready to merge as I see this issue is referenced on other tickets as well (https://issues.apache.org/jira/browse/LIBCLOUD-452) |
@mgogoulos Thanks. Can you please sync this branch with trunk and squash all the commits? Currently, I can't apply patch cleanly onto trunk. |
branch synced, commits were squashed and patch has been attached to https://issues.apache.org/jira/browse/LIBCLOUD-503 |
Merged into trunk. Thanks. |
No description provided.