LIBCLOUD-512: Added snapshot lifecycle support and fixture tests to supp... #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2014 09:00
…upport snapshot listing, creation and deletion.
…k nodes. New tests are also included.
|
|
||
| :rtype: ``bool`` | ||
| """ | ||
| return self.connection.request('/os-snapshots/%s' % snapshot.id, |
There was a problem hiding this comment.
You probably want to explicitly check the status code (e.g. response.status == httplib.DELETED) because IIRC, success() returns True for all the supported status codes/
…MX/NS records as well an additional fixture and test. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
… MX records to be broken out into separate Record objects. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
…upport snapshot listing, creation and deletion.
…hanged the response.status comparison to use httplib.NO_CONTENT for ex_delete_snapshot since no data is returned.
…/github.com/DivvyCloud/libcloud into LIBCLOUD-512_Add_OpenStack_Snapshot_Support Conflicts: libcloud/compute/drivers/openstack.py libcloud/test/compute/test_openstack.py
…different than that of OpenStack. Moving this directly into the driver clears up some of the ambiguity that came with the prior implementation.
|
I went ahead and merged this pull request with my changes into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ort snapshot listing, creation and deletion.