Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-512: Added snapshot lifecycle support and fixture tests to supp... #245

Closed
wants to merge 14 commits into from

Conversation

@cderamus
Copy link
Contributor

cderamus commented Feb 4, 2014

...ort snapshot listing, creation and deletion.

Chris DeRamus added 2 commits Feb 4, 2014
…upport snapshot listing, creation and deletion.
:rtype: ``bool``
"""
return self.connection.request('/os-snapshots/%s' % snapshot.id,

This comment has been minimized.

@Kami

Kami Feb 4, 2014 Member

You probably want to explicitly check the status code (e.g. response.status == httplib.DELETED) because IIRC, success() returns True for all the supported status codes/


# RackSpace vs. OpenStack
if 'displayName' in api_node:
return VolumeSnapshot(

This comment has been minimized.

@Kami

Kami Feb 4, 2014 Member

It seems all the arguments except extra dictionary are the same.

To reduce duplication, I would just build extra dictionary depending on the provider.

E.g.

if rackspace:
    extra = ...
else:
  extra = ...

snapshot = VolumeSnapshot(..., extra=extra)
return (httplib.OK, body, self.json_content_headers, httplib.responses[httplib.OK])

def _v1_1_slug_os_snapshots_3fbbcccf_d058_4502_8844_6feeffdf4cb5(self, method, url, body, headers):
if method == "DELETE":

This comment has been minimized.

@Kami

Kami Feb 4, 2014 Member

I noticed this in other pull request as well.

It's a minor thing, but for consistency reasons, please use single quotes around strings everywhere (except docstrings).

Chris DeRamus and others added 12 commits Feb 2, 2014
…MX/NS records as well an additional fixture and test.

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
… MX records to be broken out into separate Record objects.

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
…upport snapshot listing, creation and deletion.
…hanged the response.status comparison to use httplib.NO_CONTENT for ex_delete_snapshot since no data is returned.
…/github.com/DivvyCloud/libcloud into LIBCLOUD-512_Add_OpenStack_Snapshot_Support

Conflicts:
	libcloud/compute/drivers/openstack.py
	libcloud/test/compute/test_openstack.py
…different than that of OpenStack. Moving this directly into the driver clears up some of the ambiguity that came with the prior implementation.
@cderamus cderamus closed this Feb 6, 2014
@Kami
Copy link
Member

Kami commented Feb 6, 2014

I went ahead and merged this pull request with my changes into trunk.

Thanks!

@cderamus cderamus deleted the DivvyCloud:LIBCLOUD-512_Add_OpenStack_Snapshot_Support branch Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.