Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-512: Added snapshot lifecycle support and fixture tests to supp... #245

wants to merge 14 commits into from

LIBCLOUD-512: Added snapshot lifecycle support and fixture tests to supp... #245

wants to merge 14 commits into from


Copy link

@cderamus cderamus commented Feb 4, 2014

...ort snapshot listing, creation and deletion.

Chris DeRamus added 2 commits February 4, 2014 09:00

:rtype: ``bool``
return self.connection.request('/os-snapshots/%s' %,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to explicitly check the status code (e.g. response.status == httplib.DELETED) because IIRC, success() returns True for all the supported status codes/

Chris DeRamus and others added 12 commits February 5, 2014 14:33
…MX/NS records as well an additional fixture and test.

Signed-off-by: Tomaz Muraus <>
… MX records to be broken out into separate Record objects.

Signed-off-by: Tomaz Muraus <>
…upport snapshot listing, creation and deletion.
…hanged the response.status comparison to use httplib.NO_CONTENT for ex_delete_snapshot since no data is returned.
…/ into LIBCLOUD-512_Add_OpenStack_Snapshot_Support

…different than that of OpenStack. Moving this directly into the driver clears up some of the ambiguity that came with the prior implementation.
@cderamus cderamus closed this Feb 6, 2014
Copy link

Kami commented Feb 6, 2014

I went ahead and merged this pull request with my changes into trunk.


@cderamus cderamus deleted the LIBCLOUD-512_Add_OpenStack_Snapshot_Support branch February 6, 2014 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants