New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-516: Add list_size() support into Eucalyptus for cluster versio... #249

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@cderamus
Contributor

cderamus commented Feb 9, 2014

...ns >= 3.3.0. In this version Eucalyptus introduced the DescribeInstanceTypes call which is specific to EUCA and is not AWS compatible. This call requires a different XML namespace.

Chris DeRamus
LIBCLOUD-516: Add list_size() support into Eucalyptus for cluster ver…
…sions >= 3.3.0. In this version Eucalyptus introduced the DescribeInstanceTypes call which is specific to EUCA and is not AWS compatible. This call requires a different XML namespace.
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 9, 2014

Member

Honestly, I don't think this approach is that bad.

Member

Kami commented Feb 9, 2014

Honestly, I don't think this approach is that bad.

@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/ec2.py Outdated
Chris DeRamus
Re-working the api_version and moving it to the top level as a module…
… constant. The API version now defaults to version 3.3.0 and can be changed by passing in the api_version keyword argument.
@@ -3855,22 +3861,72 @@ class EucNodeDriver(BaseEC2NodeDriver):
connectionCls = EucConnection
def __init__(self, key, secret=None, secure=True, host=None,
path=None, port=None):
path=None, port=None, api_version=None):

This comment has been minimized.

@Kami

Kami Feb 12, 2014

Member

Shouldn't api_version default to DEFAULT_EUCA_API_VERSION?

@Kami

Kami Feb 12, 2014

Member

Shouldn't api_version default to DEFAULT_EUCA_API_VERSION?

This comment has been minimized.

@cderamus

cderamus Feb 12, 2014

Contributor

I suppose so :)

@cderamus

cderamus Feb 12, 2014

Contributor

I suppose so :)

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 12, 2014

Member

I've made the api_version change and merged patch into trunk.

Thanks.

Member

Kami commented Feb 12, 2014

I've made the api_version change and merged patch into trunk.

Thanks.

@asfgit asfgit closed this in 773cd3d Feb 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment