Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-516: Add list_size() support into Eucalyptus for cluster versio... #249

Closed
wants to merge 2 commits into from

Conversation

@cderamus
Copy link
Contributor

@cderamus cderamus commented Feb 9, 2014

...ns >= 3.3.0. In this version Eucalyptus introduced the DescribeInstanceTypes call which is specific to EUCA and is not AWS compatible. This call requires a different XML namespace.

…sions >= 3.3.0. In this version Eucalyptus introduced the DescribeInstanceTypes call which is specific to EUCA and is not AWS compatible. This call requires a different XML namespace.
@Kami
Copy link
Member

@Kami Kami commented Feb 9, 2014

Honestly, I don't think this approach is that bad.

@@ -3866,11 +3866,56 @@ def __init__(self, key, secret=None, secure=True, host=None,
if path is None:
path = '/services/Eucalyptus'
self.path = path
self.EUCA_API_VERSION = '3.4.1'

This comment has been minimized.

@Kami

Kami Feb 9, 2014
Member

To be consistent with AWS stuff, I would promote those variables to module level constants.

This comment has been minimized.

@Kami

Kami Feb 9, 2014
Member

Now, this driver could also support standard api_version argument. This argument would default to DEFAULT_EUCA_API_VERSION (or smth).

This comment has been minimized.

@cderamus

cderamus Feb 9, 2014
Author Contributor

I'm not super familiar with Eucalyptus and am only using the community cloud at the moment. Is the API version something that can dynamically be pulled?

This comment has been minimized.

@Kami

Kami Feb 9, 2014
Member

I have no idea. I know it can't be dynamically specified for AWS.

… constant. The API version now defaults to version 3.3.0 and can be changed by passing in the api_version keyword argument.
@@ -3855,22 +3861,72 @@ class EucNodeDriver(BaseEC2NodeDriver):
connectionCls = EucConnection

def __init__(self, key, secret=None, secure=True, host=None,
path=None, port=None):
path=None, port=None, api_version=None):

This comment has been minimized.

@Kami

Kami Feb 12, 2014
Member

Shouldn't api_version default to DEFAULT_EUCA_API_VERSION?

This comment has been minimized.

@cderamus

cderamus Feb 12, 2014
Author Contributor

I suppose so :)

@Kami
Copy link
Member

@Kami Kami commented Feb 12, 2014

I've made the api_version change and merged patch into trunk.

Thanks.

@asfgit asfgit closed this in 773cd3d Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.