Skip to content

[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting ...#303

Closed
amastracci wants to merge 2 commits intotrunkfrom
unknown repository
Closed

[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting ...#303
amastracci wants to merge 2 commits intotrunkfrom
unknown repository

Conversation

@amastracci
Copy link
Contributor

...base class.

Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.

…ng base class.

Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.
@Kami
Copy link
Member

Kami commented Jun 2, 2014

Looking at the differences between base and overloaded constructor - base constructor also lower cases the header keys, but it seems like RimuHosting driver never accesses response.headers properly so the driver shouldn't be affected by this.

Also, I don't have RimuHosting account so I can't test those changes myself. Have you actually tested those changes with the RimuHosting API and can confirm that they are working?

Thanks

@amastracci
Copy link
Contributor Author

Yes, I was able to successfully bring up a Rimu compute node with/without libcloud debugging. Stepped through the request/response in the debugger and the driver was correctly handling the response.

@amastracci amastracci closed this Jun 3, 2014
@Kami
Copy link
Member

Kami commented Jun 3, 2014

@amastracci I noticed you closed this pull request. Was this intentional? Or can I proceed and merge it?

@amastracci amastracci reopened this Jun 3, 2014
@amastracci
Copy link
Contributor Author

Pilot error. Yes go ahead and merge it up.

@asfgit asfgit closed this in dff5c53 Jun 3, 2014
@Kami
Copy link
Member

Kami commented Jun 3, 2014

Merged into trunk.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants