Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting ... #303
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Jun 2, 2014
Member
Looking at the differences between base and overloaded constructor - base constructor also lower cases the header keys, but it seems like RimuHosting driver never accesses response.headers properly so the driver shouldn't be affected by this.
Also, I don't have RimuHosting account so I can't test those changes myself. Have you actually tested those changes with the RimuHosting API and can confirm that they are working?
Thanks
|
Looking at the differences between base and overloaded constructor - base constructor also lower cases the header keys, but it seems like RimuHosting driver never accesses Also, I don't have RimuHosting account so I can't test those changes myself. Have you actually tested those changes with the RimuHosting API and can confirm that they are working? Thanks |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
amastracci
Jun 3, 2014
Contributor
Yes, I was able to successfully bring up a Rimu compute node with/without libcloud debugging. Stepped through the request/response in the debugger and the driver was correctly handling the response.
|
Yes, I was able to successfully bring up a Rimu compute node with/without libcloud debugging. Stepped through the request/response in the debugger and the driver was correctly handling the response. |
amastracci
closed this
Jun 3, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Jun 3, 2014
Member
@amastracci I noticed you closed this pull request. Was this intentional? Or can I proceed and merge it?
|
@amastracci I noticed you closed this pull request. Was this intentional? Or can I proceed and merge it? |
amastracci
reopened this
Jun 3, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Pilot error. Yes go ahead and merge it up. |
asfgit
closed this
in
dff5c53
Jun 3, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Merged into trunk. Thanks. |
added a commit
to Pertino/libcloud
that referenced
this pull request
Jun 3, 2014
amastracci commentedJun 1, 2014
...base class.
Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.