New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting ... #303

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@amastracci
Contributor

amastracci commented Jun 1, 2014

...base class.

Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.

[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosti…
…ng base class.

Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 2, 2014

Member

Looking at the differences between base and overloaded constructor - base constructor also lower cases the header keys, but it seems like RimuHosting driver never accesses response.headers properly so the driver shouldn't be affected by this.

Also, I don't have RimuHosting account so I can't test those changes myself. Have you actually tested those changes with the RimuHosting API and can confirm that they are working?

Thanks

Member

Kami commented Jun 2, 2014

Looking at the differences between base and overloaded constructor - base constructor also lower cases the header keys, but it seems like RimuHosting driver never accesses response.headers properly so the driver shouldn't be affected by this.

Also, I don't have RimuHosting account so I can't test those changes myself. Have you actually tested those changes with the RimuHosting API and can confirm that they are working?

Thanks

@amastracci

This comment has been minimized.

Show comment
Hide comment
@amastracci

amastracci Jun 3, 2014

Contributor

Yes, I was able to successfully bring up a Rimu compute node with/without libcloud debugging. Stepped through the request/response in the debugger and the driver was correctly handling the response.

Contributor

amastracci commented Jun 3, 2014

Yes, I was able to successfully bring up a Rimu compute node with/without libcloud debugging. Stepped through the request/response in the debugger and the driver was correctly handling the response.

@amastracci amastracci closed this Jun 3, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 3, 2014

Member

@amastracci I noticed you closed this pull request. Was this intentional? Or can I proceed and merge it?

Member

Kami commented Jun 3, 2014

@amastracci I noticed you closed this pull request. Was this intentional? Or can I proceed and merge it?

@amastracci amastracci reopened this Jun 3, 2014

@amastracci

This comment has been minimized.

Show comment
Hide comment
@amastracci

amastracci Jun 3, 2014

Contributor

Pilot error. Yes go ahead and merge it up.

Contributor

amastracci commented Jun 3, 2014

Pilot error. Yes go ahead and merge it up.

@asfgit asfgit closed this in dff5c53 Jun 3, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 3, 2014

Member

Merged into trunk.

Thanks.

Member

Kami commented Jun 3, 2014

Merged into trunk.

Thanks.

amastracci added a commit to Pertino/libcloud that referenced this pull request Jun 3, 2014

[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosti…
…ng base class.

Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.

Closes #303

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment