[LIBCLOUD-569] Removing the overloaded constructor from the rimuhosting ... #303
Conversation
…ng base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.
|
Looking at the differences between base and overloaded constructor - base constructor also lower cases the header keys, but it seems like RimuHosting driver never accesses Also, I don't have RimuHosting account so I can't test those changes myself. Have you actually tested those changes with the RimuHosting API and can confirm that they are working? Thanks |
|
Yes, I was able to successfully bring up a Rimu compute node with/without libcloud debugging. Stepped through the request/response in the debugger and the driver was correctly handling the response. |
|
@amastracci I noticed you closed this pull request. Was this intentional? Or can I proceed and merge it? |
|
Pilot error. Yes go ahead and merge it up. |
…server memory values.
|
Merged into trunk. Thanks. |
…ng base class. Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase. Closes apache#303 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
...base class.
Rimu uses gzip'ed responses but the overloaded constructor was not calling the decompress function resuuulting in a MalformedResponseError. All functionality in overloaded constructor already existed in the base clase.