New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-572 internet-gateways-filters for ec2 driver #307

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@zerthimon
Contributor

zerthimon commented Jun 3, 2014

Extend EC2 driver ex_list_internet_gateways() method with ability to provide internet gateway ID and filters to list only specific internet gateways.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 4, 2014

Member

Lint is failing, besides that, LGTM.

/cc @cderamus

Member

Kami commented Jun 4, 2014

Lint is failing, besides that, LGTM.

/cc @cderamus

@zerthimon

This comment has been minimized.

Show comment
Hide comment
@zerthimon

zerthimon Jun 4, 2014

Contributor

Why is lint failing ? Is there anything I can fix ?

Contributor

zerthimon commented Jun 4, 2014

Why is lint failing ? Is there anything I can fix ?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 4, 2014

Member

Yes, just some trailing whitespace - https://travis-ci.org/apache/libcloud/jobs/26680711#L48

Member

Kami commented Jun 4, 2014

Yes, just some trailing whitespace - https://travis-ci.org/apache/libcloud/jobs/26680711#L48

@zerthimon

This comment has been minimized.

Show comment
Hide comment
@zerthimon

zerthimon Jun 4, 2014

Contributor

fixed

Contributor

zerthimon commented Jun 4, 2014

fixed

@asfgit asfgit closed this in ee39aad Jun 23, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 23, 2014

Member

Updated the code to use _pathlist, squashed the commits and merged changes into trunk. Thanks.

Member

Kami commented Jun 23, 2014

Updated the code to use _pathlist, squashed the commits and merged changes into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment