Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[LIBCLOUD-611] Added ex_create_image for the GCE compute provider #358
Conversation
Kami
reviewed
Sep 12, 2014
libcloud/compute/drivers/gce.py
| :param name: The name of the image to create. | ||
| :type name: ``str`` | ||
| :param volume: The disk to use to create the node, or the Google Cloud |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
reviewed
Sep 12, 2014
libcloud/compute/drivers/gce.py
| :param volume: The disk to use to create the node, or the Google Cloud | ||
| Storage URI | ||
| :type image: ``str`` or :class:`StorageVolume` |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
reviewed
Sep 12, 2014
libcloud/compute/drivers/gce.py
| def ex_create_image(self, name, volume, description=None, | ||
| use_existing=True, wait_for_completion=True): | ||
| """ | ||
| Create an Image. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Sep 12, 2014
Member
For explicitness sake it would probably be better to say something along the lines of `Create an image based on the provided volume.
Kami
Sep 12, 2014
Member
For explicitness sake it would probably be better to say something along the lines of `Create an image based on the provided volume.
katrielt
added some commits
Sep 17, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Sep 23, 2014
Member
@katrielt Can you please synchronize your branch with trunk and squash all the commits (I'm having problems merging this directly into trunk).
Also, next time feel free to ping me after you address the issues since I don't receive a notification when you push new commits.
|
@katrielt Can you please synchronize your branch with trunk and squash all the commits (I'm having problems merging this directly into trunk). Also, next time feel free to ping me after you address the issues since I don't receive a notification when you push new commits. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
katrielt
Sep 23, 2014
Contributor
Thanks for the ping. Was un-aware of that.
I've attached the squashed and formatted patch to the jira case at https://issues.apache.org/jira/browse/LIBCLOUD-611
|
Thanks for the ping. Was un-aware of that. |
asfgit
closed this
in
a6961ce
Sep 23, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Sep 23, 2014
Member
I still had some issues with applying the patch since it appears your branch is not synchronized with trunk, but I went ahead and picked the changes manually.
Changes are merged into trunk now - thanks.
|
I still had some issues with applying the patch since it appears your branch is not synchronized with trunk, but I went ahead and picked the changes manually. Changes are merged into trunk now - thanks. |
katrielt
deleted the
katrielt:LIBCLOUD-611-support_create_image
branch
Sep 23, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
katrielt
Sep 23, 2014
Contributor
That is weird, as I pulled from the upstream repo. at https://git-wip-us.apache.org/repos/asf/libcloud.git. Anyway, thank you.
|
That is weird, as I pulled from the upstream repo. at https://git-wip-us.apache.org/repos/asf/libcloud.git. Anyway, thank you. |
katrielt commentedSep 11, 2014
Resolves https://issues.apache.org/jira/browse/LIBCLOUD-611