Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[LIBCLOUD-611] Added ex_create_image for the GCE compute provider #358
Conversation
| :param name: The name of the image to create. | ||
| :type name: ``str`` | ||
| :param volume: The disk to use to create the node, or the Google Cloud |
Kami
Sep 12, 2014
Member
Docstrings need to be updated.
Docstrings need to be updated.
| :param volume: The disk to use to create the node, or the Google Cloud | ||
| Storage URI | ||
| :type image: ``str`` or :class:`StorageVolume` |
Kami
Sep 12, 2014
Member
This should be type volume
This should be type volume
| def ex_create_image(self, name, volume, description=None, | ||
| use_existing=True, wait_for_completion=True): | ||
| """ | ||
| Create an Image. |
Kami
Sep 12, 2014
Member
For explicitness sake it would probably be better to say something along the lines of `Create an image based on the provided volume.
For explicitness sake it would probably be better to say something along the lines of `Create an image based on the provided volume.
…ixes to docstring after pull request review
…ixed long string in docstring
|
@katrielt Can you please synchronize your branch with trunk and squash all the commits (I'm having problems merging this directly into trunk). Also, next time feel free to ping me after you address the issues since I don't receive a notification when you push new commits. |
…OUD-611-support_create_image
|
Thanks for the ping. Was un-aware of that. |
|
I still had some issues with applying the patch since it appears your branch is not synchronized with trunk, but I went ahead and picked the changes manually. Changes are merged into trunk now - thanks. |
|
That is weird, as I pulled from the upstream repo. at https://git-wip-us.apache.org/repos/asf/libcloud.git. Anyway, thank you. |
Resolves https://issues.apache.org/jira/browse/LIBCLOUD-611