Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-611] Added ex_create_image for the GCE compute provider #358

Closed

Conversation

katrielt
Copy link
Contributor

:param name: The name of the image to create.
:type name: ``str``

:param volume: The disk to use to create the node, or the Google Cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings need to be updated.

@Kami
Copy link
Member

Kami commented Sep 23, 2014

@katrielt Can you please synchronize your branch with trunk and squash all the commits (I'm having problems merging this directly into trunk).

Also, next time feel free to ping me after you address the issues since I don't receive a notification when you push new commits.

@katrielt
Copy link
Contributor Author

Thanks for the ping. Was un-aware of that.
I've attached the squashed and formatted patch to the jira case at https://issues.apache.org/jira/browse/LIBCLOUD-611

@asfgit asfgit closed this in a6961ce Sep 23, 2014
@Kami
Copy link
Member

Kami commented Sep 23, 2014

I still had some issues with applying the patch since it appears your branch is not synchronized with trunk, but I went ahead and picked the changes manually.

Changes are merged into trunk now - thanks.

@katrielt katrielt deleted the LIBCLOUD-611-support_create_image branch September 23, 2014 13:13
@katrielt
Copy link
Contributor Author

That is weird, as I pulled from the upstream repo. at https://git-wip-us.apache.org/repos/asf/libcloud.git. Anyway, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants