New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google compute] Add missing attributes/methods to create_node() #419

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
1 participant
@erjohnso
Member

erjohnso commented Dec 18, 2014

@Kami, @runseb - I would appreciate a review of this one. This PR has the potential to break GCE users, but the demos/gce_demo.py and tox tests are all good, so I think it's in good shape.

Improvements to Node. Adding missing attributes and methods to make it match the GCE API.

  • Added Node attributes such as canIpForward, serviceAccounts, etc to node['extra'].
  • Added ex_add_access_config()
  • Added ex_delete_access_config()
  • Added ex_set_node_metadata()
  • Added ex_get_serial_output()

The newly added attributes and methods docs are covered at https://cloud.google.com/compute/docs/reference/latest/instances

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Dec 19, 2014

Member

FYI - I also tested using this branch with the GCE drivers for both ansible and salt-cloud, so I'm feeling good about not breaking folks.

Member

erjohnso commented Dec 19, 2014

FYI - I also tested using this branch with the GCE drivers for both ansible and salt-cloud, so I'm feeling good about not breaking folks.

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Dec 29, 2014

Member

When I made the last two minor changes, it resulted in a merge conflict. I made a minor edit to allow a clean merge and rebased.

Member

erjohnso commented Dec 29, 2014

When I made the last two minor changes, it resulted in a merge conflict. I made a minor edit to allow a clean merge and rebased.

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Jan 5, 2015

Member

Added a snippet to demos/gce_demo.py to show how to use the new multi-disks param when creating nodes. Once travis passes, I plan to go ahead and merge this.

Member

erjohnso commented Jan 5, 2015

Added a snippet to demos/gce_demo.py to show how to use the new multi-disks param when creating nodes. Once travis passes, I plan to go ahead and merge this.

@asfgit asfgit closed this in 7771e18 Jan 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment