Skip to content

[google compute] Add missing attributes/methods to create_node()#419

Closed
erjohnso wants to merge 1 commit intoapache:trunkfrom
erjohnso:GCE_Instances
Closed

[google compute] Add missing attributes/methods to create_node()#419
erjohnso wants to merge 1 commit intoapache:trunkfrom
erjohnso:GCE_Instances

Conversation

@erjohnso
Copy link
Contributor

@Kami, @Runseb - I would appreciate a review of this one. This PR has the potential to break GCE users, but the demos/gce_demo.py and tox tests are all good, so I think it's in good shape.

Improvements to Node. Adding missing attributes and methods to make it match the GCE API.

  • Added Node attributes such as canIpForward, serviceAccounts, etc to node['extra'].
  • Added ex_add_access_config()
  • Added ex_delete_access_config()
  • Added ex_set_node_metadata()
  • Added ex_get_serial_output()

The newly added attributes and methods docs are covered at https://cloud.google.com/compute/docs/reference/latest/instances

@erjohnso
Copy link
Contributor Author

FYI - I also tested using this branch with the GCE drivers for both ansible and salt-cloud, so I'm feeling good about not breaking folks.

@erjohnso
Copy link
Contributor Author

When I made the last two minor changes, it resulted in a merge conflict. I made a minor edit to allow a clean merge and rebased.

@erjohnso
Copy link
Contributor Author

erjohnso commented Jan 5, 2015

Added a snippet to demos/gce_demo.py to show how to use the new multi-disks param when creating nodes. Once travis passes, I plan to go ahead and merge this.

@asfgit asfgit closed this in 7771e18 Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant