[google compute] Add missing attributes/methods to create_node() #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - I also tested using this branch with the GCE drivers for both ansible and salt-cloud, so I'm feeling good about not breaking folks. |
erjohnso
force-pushed
the
GCE_Instances
branch
from
7f8875d
to
d680bc6
Compare
|
When I made the last two minor changes, it resulted in a merge conflict. I made a minor edit to allow a clean merge and rebased. |
erjohnso
force-pushed
the
GCE_Instances
branch
from
d680bc6
to
c8e6c54
Compare
|
Added a snippet to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kami, @Runseb - I would appreciate a review of this one. This PR has the potential to break GCE users, but the
demos/gce_demo.pyand tox tests are all good, so I think it's in good shape.Improvements to Node. Adding missing attributes and methods to make it match the GCE API.
canIpForward,serviceAccounts, etc tonode['extra'].ex_add_access_config()ex_delete_access_config()ex_set_node_metadata()ex_get_serial_output()The newly added attributes and methods docs are covered at https://cloud.google.com/compute/docs/reference/latest/instances