@Added JoyentNodeDriver.ex_get_node() #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joyent didn't have a method for get only one Node. Because I doesn't want to make a for loop for find a node, I added this method. Error raising is better too with that, a real Joyent's error message is now raised.
| :return: A Node object for the node | ||
| :rtype: :class:`Node` | ||
| """ | ||
| result = self.connection.request('/my/machines/%s' % node.id) |
There was a problem hiding this comment.
Please use parenthesis around format string arguments - % (node.id)
|
Thanks. Overall it looks good, but we need a test case for it and lint failure needs to be fixed - https://travis-ci.org/apache/libcloud/builds/45025149 |
|
I use my_machines_single.json for mock a single machine. |
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joyent didn't have a method for get only one Node.
Because I doesn't want to make a for loop for find a node, I added this method.
Error raising is better too with that, a real Joyent's error message is now raised.