New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Added JoyentNodeDriver.ex_get_node() #421

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@ZuluPro
Contributor

ZuluPro commented Dec 24, 2014

Joyent didn't have a method for get only one Node.

Because I doesn't want to make a for loop for find a node, I added this method.
Error raising is better too with that, a real Joyent's error message is now raised.

Added JoyentNodeDriver.ex_get_node()
Joyent didn't have a method for get only one Node.

Because I doesn't want to make a for loop for find a node, I added this method.
Error raising is better too with that, a real Joyent's error message is now raised.
@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/joyent.py
:return: A Node object for the node
:rtype: :class:`Node`
"""
result = self.connection.request('/my/machines/%s' % node.id)

This comment has been minimized.

@Kami

Kami Dec 24, 2014

Member

Please use parenthesis around format string arguments - % (node.id)

@Kami

Kami Dec 24, 2014

Member

Please use parenthesis around format string arguments - % (node.id)

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 24, 2014

Member

Thanks.

Overall it looks good, but we need a test case for it and lint failure needs to be fixed - https://travis-ci.org/apache/libcloud/builds/45025149

Member

Kami commented Dec 24, 2014

Thanks.

Overall it looks good, but we need a test case for it and lint failure needs to be fixed - https://travis-ci.org/apache/libcloud/builds/45025149

@ZuluPro

This comment has been minimized.

Show comment
Hide comment
@ZuluPro

ZuluPro Dec 25, 2014

Contributor

I use my_machines_single.json for mock a single machine.

Contributor

ZuluPro commented Dec 25, 2014

I use my_machines_single.json for mock a single machine.

@asfgit asfgit closed this in 68a3461 Dec 26, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 26, 2014

Member

Merged into trunk. Thanks.

Member

Kami commented Dec 26, 2014

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment