[google compute] LIBCLOUD-657 add support for JSON private key format #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google has introduced a new JSON formatted private key for Service Accounts. This PR adds support for the new format along with some improved handling of files vs strings for the key value. Docs have been updated to inform users Google prefers the JSON format versus legacy P12 format.
/cc @windo - This PR also includes the patch from Siim Poder via LIBCLOUD-627 to fix auth with Python 3.
Manual testing was done for the various file formats and using Python 2.7 and 3.2.
/cc @carlcrott since I broke you last time I touched GCE auth and if I do it again, he'll give me a 👊