[google compute] LIBCLOUD-657 add support for JSON private key format #438

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@erjohnso
Member

erjohnso commented Jan 23, 2015

Google has introduced a new JSON formatted private key for Service Accounts. This PR adds support for the new format along with some improved handling of files vs strings for the key value. Docs have been updated to inform users Google prefers the JSON format versus legacy P12 format.

/cc @windo - This PR also includes the patch from Siim Poder via LIBCLOUD-627 to fix auth with Python 3.

Manual testing was done for the various file formats and using Python 2.7 and 3.2.

/cc @carlcrott since I broke you last time I touched GCE auth and if I do it again, he'll give me a 馃憡

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 26, 2015

Member

LGTM

Member

Kami commented Jan 26, 2015

LGTM

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 26, 2015

Member

Please also update CHANGES file.

Member

Kami commented Jan 26, 2015

Please also update CHANGES file.

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Jan 26, 2015

Member

Will do, thanks @Kami.

Member

erjohnso commented Jan 26, 2015

Will do, thanks @Kami.

@asfgit asfgit closed this in ab7d07b Jan 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment