[LIBCLOUD-664] EC2 driver breaks contract with base driver in list_volume_snapshots
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why this build suddenly fails when I did not change a significant thing. |
|
Tests fixed. |
|
|
||
| :param volume: the StorageVolume to filter on | ||
| :return: a list of all VolumeSnapshots for the given StorageVolume | ||
| :rtype: [VolumeSnapshot] |
There was a problem hiding this comment.
Please change it to:
:rtype: ``list`` of :class:`VolumeSnapshot`
There was a problem hiding this comment.
Actually, you can remove this docstring all together since the method in the base class already has a doctring and this method signature matches the base method's signature.
There was a problem hiding this comment.
Aaaand it's gone.
|
Docstring also removed from related #450 |
|
For some reason the patch doesn't apply cleanly. Can you please sync your branch with master and squash all the commits? |
allardhoeve
force-pushed
the
ec2-driver-conforms-to-contract-list-volume-snapshots
branch
from
6dfa72e
to
9fa614a
Compare
|
Did |
|
Merged into trunk. Thanks. Next time please mention my nickname since we don't get notified about new comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.