Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-664] EC2 driver breaks contract with base driver in `list_volume_snapshots` #451

Conversation

@allardhoeve
Copy link
Contributor

@allardhoeve allardhoeve commented Feb 12, 2015

No description provided.

@allardhoeve
Copy link
Contributor Author

@allardhoeve allardhoeve commented Feb 17, 2015

I don't understand why this build suddenly fails when I did not change a significant thing.

@allardhoeve
Copy link
Contributor Author

@allardhoeve allardhoeve commented Feb 18, 2015

Tests fixed.

:param volume: the StorageVolume to filter on
:return: a list of all VolumeSnapshots for the given StorageVolume
:rtype: [VolumeSnapshot]

This comment has been minimized.

@Kami

Kami Feb 18, 2015
Member

Please change it to:

:rtype: ``list`` of :class:`VolumeSnapshot`

This comment has been minimized.

@Kami

Kami Feb 18, 2015
Member

Actually, you can remove this docstring all together since the method in the base class already has a doctring and this method signature matches the base method's signature.

This comment has been minimized.

@allardhoeve

allardhoeve Feb 18, 2015
Author Contributor

Aaaand it's gone.

@allardhoeve
Copy link
Contributor Author

@allardhoeve allardhoeve commented Feb 18, 2015

Docstring also removed from related #450

@Kami
Copy link
Member

@Kami Kami commented Feb 19, 2015

For some reason the patch doesn't apply cleanly.

Can you please sync your branch with master and squash all the commits?

Allard Hoeve
@allardhoeve allardhoeve force-pushed the ByteInternet:ec2-driver-conforms-to-contract-list-volume-snapshots branch from 6dfa72e to 9fa614a Feb 20, 2015
@allardhoeve
Copy link
Contributor Author

@allardhoeve allardhoeve commented Feb 20, 2015

Did git rebase -i and squashed it all.

@asfgit asfgit closed this in 6a281fd Feb 20, 2015
@Kami
Copy link
Member

@Kami Kami commented Feb 20, 2015

Merged into trunk. Thanks.

Next time please mention my nickname since we don't get notified about new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants