/libcloud

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-664] EC2 driver breaks contract with base driver in `list_volume_snapshots` #451

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@allardhoeve @Kami
@allardhoeve
Contributor

allardhoeve commented Feb 12, 2015

No description provided.

@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 17, 2015

Contributor

I don't understand why this build suddenly fails when I did not change a significant thing.
Contributor

allardhoeve commented Feb 17, 2015

I don't understand why this build suddenly fails when I did not change a significant thing.
@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 18, 2015

Contributor

Tests fixed.
Contributor

allardhoeve commented Feb 18, 2015

Tests fixed.
Show outdated Hide outdated libcloud/compute/drivers/ec2.py
:param volume: the StorageVolume to filter on
:return: a list of all VolumeSnapshots for the given StorageVolume
:rtype: [VolumeSnapshot]

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 18, 2015

Member

Please change it to:

:rtype: ``list`` of :class:`VolumeSnapshot`
Copy URL
@Kami

Kami Feb 18, 2015

Member

Please change it to:

:rtype: ``list`` of :class:`VolumeSnapshot`

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 18, 2015

Member

Actually, you can remove this docstring all together since the method in the base class already has a doctring and this method signature matches the base method's signature.
Copy URL
@Kami

Kami Feb 18, 2015

Member

Actually, you can remove this docstring all together since the method in the base class already has a doctring and this method signature matches the base method's signature.

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 18, 2015

Contributor

Aaaand it's gone.
Copy URL
@allardhoeve

allardhoeve Feb 18, 2015

Contributor

Aaaand it's gone.
@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 18, 2015

Contributor

Docstring also removed from related #450
Contributor

allardhoeve commented Feb 18, 2015

Docstring also removed from related #450

@allardhoeve allardhoeve referenced this pull request Feb 18, 2015

Closed

[LIBCLOUD-663] List volume snapshots for openstack #450

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 19, 2015

Member

For some reason the patch doesn't apply cleanly.

Can you please sync your branch with master and squash all the commits?
Member

Kami commented Feb 19, 2015

For some reason the patch doesn't apply cleanly.

Can you please sync your branch with master and squash all the commits?
@allardhoeve

This comment has been minimized.

Show comment
Hide comment
@allardhoeve

allardhoeve Feb 20, 2015

Contributor

Did git rebase -i and squashed it all.
Contributor

allardhoeve commented Feb 20, 2015

Did git rebase -i and squashed it all.

@asfgit asfgit closed this in 6a281fd Feb 20, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 20, 2015

Member

Merged into trunk. Thanks.

Next time please mention my nickname since we don't get notified about new comments.
Member

Kami commented Feb 20, 2015

Merged into trunk. Thanks.

Next time please mention my nickname since we don't get notified about new comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment