New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List VPCs project support #516

Closed
wants to merge 4 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@syed
Contributor

syed commented May 13, 2015

Adding support to list VPCs which are in a project.

@@ -1798,14 +1798,20 @@ def ex_list_vpc_offerings(self):
return vpcofferings
def ex_list_vpcs(self):
def ex_list_vpcs(self, project=None):
"""
List the available VPCs

This comment has been minimized.

@Kami

Kami May 16, 2015

Member

Please add a docstring which indicates what project argument does.

@Kami

Kami May 16, 2015

Member

Please add a docstring which indicates what project argument does.

This comment has been minimized.

@Kami

Kami May 16, 2015

Member

Besides that, LGTM.

@Kami

Kami May 16, 2015

Member

Besides that, LGTM.

@asfgit asfgit closed this in 9fefa0c Aug 9, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Aug 9, 2015

Member

Sorry for the delay.

I don't get notified when you push new commits so I didn't notice you addressed the comment.

In any case, patch has been merged into trunk now. Thanks.

Member

Kami commented Aug 9, 2015

Sorry for the delay.

I don't get notified when you push new commits so I didn't notice you addressed the comment.

In any case, patch has been merged into trunk now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment