New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-710] Updated CloudSigma's NODE_STATE_MAP to use new-ish Nod… #517

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@chrisob
Contributor

chrisob commented May 13, 2015

@@ -984,10 +984,10 @@ class CloudSigma_2_0_NodeDriver(CloudSigmaNodeDriver):
NODE_STATE_MAP = {
'starting': NodeState.PENDING,
'stopping': NodeState.PENDING,
'unavailable': NodeState.PENDING,

This comment has been minimized.

@Kami

Kami May 16, 2015

Member

@vpetersson Is mapping "unavailable" to "error" indeed more correct than mapping it to "pending" - aka can node come out of the "unavailable" state?

@Kami

Kami May 16, 2015

Member

@vpetersson Is mapping "unavailable" to "error" indeed more correct than mapping it to "pending" - aka can node come out of the "unavailable" state?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 16, 2015

Member

Thanks.

Will wait for @vpetersson's response about the new mapping for the "unavailable" state. The pause one looks good to me though.

Member

Kami commented May 16, 2015

Thanks.

Will wait for @vpetersson's response about the new mapping for the "unavailable" state. The pause one looks good to me though.

@vpetersson

This comment has been minimized.

Show comment
Hide comment
@vpetersson

vpetersson May 16, 2015

Contributor

@Kami 'unavailable' is a tricky one. In most cases, it's just a temporary error, but it's really a catch-all error when we're able to get the proper status from the host. Perhaps @gcbirzan can chime in with a more detailed explanation.

Contributor

vpetersson commented May 16, 2015

@Kami 'unavailable' is a tricky one. In most cases, it's just a temporary error, but it's really a catch-all error when we're able to get the proper status from the host. Perhaps @gcbirzan can chime in with a more detailed explanation.

@chrisob

This comment has been minimized.

Show comment
Hide comment
@chrisob

chrisob May 17, 2015

Contributor

From what I understand, unavailable is indeed usually a temporary status,
but while a server is in state unavailable, no API actions can be taken on
it (API returns a 500 error when attempting to interact with an unavailable
sever), thus why I figured ERROR would be the best state map for it.
Hopefully Cristian has something to say about this though :)

Just curious, does NodeState.ERROR usually imply an unrecoverable error?

On Sat, May 16, 2015, 21:17 Viktor Petersson notifications@github.com
wrote:

@Kami https://github.com/Kami 'unavailable' is a tricky one. In most
cases, it's just a temporary error, but it's really a catch-all error when
we're able to get the proper status from the host. Perhaps @gcbirzan
https://github.com/gcbirzan can chime in with a more detailed
explanation.


Reply to this email directly or view it on GitHub
#517 (comment).

Contributor

chrisob commented May 17, 2015

From what I understand, unavailable is indeed usually a temporary status,
but while a server is in state unavailable, no API actions can be taken on
it (API returns a 500 error when attempting to interact with an unavailable
sever), thus why I figured ERROR would be the best state map for it.
Hopefully Cristian has something to say about this though :)

Just curious, does NodeState.ERROR usually imply an unrecoverable error?

On Sat, May 16, 2015, 21:17 Viktor Petersson notifications@github.com
wrote:

@Kami https://github.com/Kami 'unavailable' is a tricky one. In most
cases, it's just a temporary error, but it's really a catch-all error when
we're able to get the proper status from the host. Perhaps @gcbirzan
https://github.com/gcbirzan can chime in with a more detailed
explanation.


Reply to this email directly or view it on GitHub
#517 (comment).

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami May 17, 2015

Member

@chrisob Yeah, ERROR usually implies an end state which is not recoverable.

I don't think we have any detailed docs on the states right now, but I will make sure they get added.

Member

Kami commented May 17, 2015

@chrisob Yeah, ERROR usually implies an end state which is not recoverable.

I don't think we have any detailed docs on the states right now, but I will make sure they get added.

chrisob added a commit that referenced this pull request Jun 6, 2015

Updated CloudSigma's NODE_STATE_MAP to use new-ish NodeStates
Closes #517

Signed-off-by: Tomaz Muraus <tomaz@tomaz.me>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 13, 2015

Member

This has been merged a while ago.

Can you please close the PR?

Member

Kami commented Jun 13, 2015

This has been merged a while ago.

Can you please close the PR?

@asfgit asfgit closed this in 699584f Jun 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment