-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIBCLOUD-749] CloudStack: fixed method ex_authorize_security_group_ingress #580
[LIBCLOUD-749] CloudStack: fixed method ex_authorize_security_group_ingress #580
Conversation
def ex_authorize_security_group_ingress(self, securitygroupname, protocol, | ||
cidrlist, startport=None, | ||
endport=None, icmptype=None, | ||
icmpcode=None, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explicitly declare all the supported arguments instead of using **kwargs?
Added one comment, besides that, LGTM. Thanks. /cc @Runseb |
LGTM, I will merge in the coming days |
…urity_group_ingress
@Kami : Thanks for the comment which allowed me to discover a small issue in the docstring (
Yes, of course. I used To be consistent I would suggest to keep it like this. |
Sorry for the delay - I went ahead and merged the changes. For now, lets keep |
Closes #580 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
…x_authorize_security_group_ingress Closes #580 Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Corresponding ticket in the JIRA issue tracker: LIBCLOUD-749
This PR fixes the following bugs:
ICMP
andTCP
is allowed even if the doc of the parameterprotocol
mentionTCP
andUDP
.ICMP
cannot be used because there is no way to specify the two required parametersicmptype
andicmpcode
.endport
is not used if it's defined.list
but adict
.This PR also does the following changes:
kwargs
to allow to provide extra parameters defined in the API and in the docstring.AH
,GRE
andESP
which are available on some Cloud like Exoscale.