New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-759 Updated pricing.json file to include data from SoftLayer #603

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@davidwilson2038
Contributor

davidwilson2038 commented Oct 15, 2015

Updated pricing.json file to include data from SoftLayer. I got this pricing data by launching each type of node and looking at its "hourlyRecurringFee" attribute in its extras dictionary.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 15, 2015

Member

Thanks, but for this actually to work you also need to update the driver to use this information.

See:

  1. https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/softlayer.py#L441
  2. https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudsigma.py#L251 - an example of how to retrieve the size pricing from the pricing file
Member

Kami commented Oct 15, 2015

Thanks, but for this actually to work you also need to update the driver to use this information.

See:

  1. https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/softlayer.py#L441
  2. https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudsigma.py#L251 - an example of how to retrieve the size pricing from the pricing file
@davidwilson2038

This comment has been minimized.

Show comment
Hide comment
@davidwilson2038

davidwilson2038 Oct 15, 2015

Contributor

@Kami My apologies for missing that. Thanks for the hint on what to fix. My latest commit should have it working successfully (tested with list_sizes).

Contributor

davidwilson2038 commented Oct 15, 2015

@Kami My apologies for missing that. Thanks for the hint on what to fix. My latest commit should have it working successfully (tested with list_sizes).

@asfgit asfgit closed this in a73e7b2 Oct 19, 2015

asfgit pushed a commit that referenced this pull request Oct 19, 2015

LIBCLOUD-759 Changed SoftLayer Node driver to use pricing information
Closes #603

Signed-off-by: Tomaz Muraus <tomaz@apache.org>
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 19, 2015

Member

Added a small test case (0ca7651) and merged it into trunk.

Thanks!

Member

Kami commented Oct 19, 2015

Added a small test case (0ca7651) and merged it into trunk.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment