Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLIBCLOUD-759 Updated pricing.json file to include data from SoftLayer #603
Conversation
|
Thanks, but for this actually to work you also need to update the driver to use this information. See:
|
|
@Kami My apologies for missing that. Thanks for the hint on what to fix. My latest commit should have it working successfully (tested with list_sizes). |
asfgit
pushed a commit
that referenced
this pull request
Oct 19, 2015
|
Added a small test case (0ca7651) and merged it into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
davidwilson2038 commentedOct 15, 2015
Updated pricing.json file to include data from SoftLayer. I got this pricing data by launching each type of node and looking at its "hourlyRecurringFee" attribute in its extras dictionary.