Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLIBCLOUD-759 Updated pricing.json file to include data from SoftLayer #603
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Kami
Oct 15, 2015
Member
Thanks, but for this actually to work you also need to update the driver to use this information.
See:
- https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/softlayer.py#L441
- https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudsigma.py#L251 - an example of how to retrieve the size pricing from the pricing file
|
Thanks, but for this actually to work you also need to update the driver to use this information. See:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
davidwilson2038
Oct 15, 2015
Contributor
@Kami My apologies for missing that. Thanks for the hint on what to fix. My latest commit should have it working successfully (tested with list_sizes).
|
@Kami My apologies for missing that. Thanks for the hint on what to fix. My latest commit should have it working successfully (tested with list_sizes). |
asfgit
closed this
in
a73e7b2
Oct 19, 2015
pushed a commit
that referenced
this pull request
Oct 19, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Added a small test case (0ca7651) and merged it into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davidwilson2038 commentedOct 15, 2015
Updated pricing.json file to include data from SoftLayer. I got this pricing data by launching each type of node and looking at its "hourlyRecurringFee" attribute in its extras dictionary.