-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clearer travis display & clean tox.ini #608
Conversation
before_script: TOX_ENV=lint | ||
- python: 2.7 | ||
env: ENV=docs | ||
before_script: TOX_ENV=docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env
is only used for display
before_script
allows me to override value defined in install
section.
Thanks. I'm fine with that change, but it will break if Travis CI drops support for some Python version we still support, right? In short - I'm fine with merging it, but we will need to revert this change in case Travis drops support for a Python version so we just need to document that - I guess we can just add a comment to the travis yaml file. |
No more things than before. We supports Python 2.5, have it in tox.ini, but can't test with Travis.
I'm doing... |
@ZuluPro please let me know when you make those changes and I'll go ahead and merge this PR. |
@ZuluPro Bump^ Would be great to get this addressed and merged. |
Sorry I'll do it tomorow ! |
a507a08
to
62e855a
Compare
c4ec686
to
9ce99b8
Compare
@@ -1,52 +1,28 @@ | |||
[tox] | |||
envlist = py25,py26,py27,pypy,py32,py33,py34,lint | |||
setenv = | |||
PIP_USE_MIRRORS=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not supported anymore: chnm/serendipomatic#158
Done ! |
@ZuluPro Thanks. Next time please mention my nickname, since if you are not replying to my comment, I don't get a notification. As far as tox changes go, I get this error: kami ~/w/lc/libcloud (git:trunk)$ tox
ERROR: unknown environment 'py3.5' Is this functionality only available in newer versions of tox or is there something else going on? |
Actually, ignore my last comment. I just noticed python3.5 is not defined in |
There is also an issue with pypy ERROR: pypypy: could not install deps [-r/home/kami/w/lc/libcloud/requirements-tests.txt, lockfile, paramiko]; v = InvocationError('/home/kami/w/lc/libcloud/.tox/pypypy/bin/pip install --pre -r/home/kami/w/lc/libcloud/requirements-tests.txt lockfile paramiko (see /home/kami/w/lc/libcloud/.tox/pypypy/log/pypypy-1.log)', 1) Looks like the issue is related to paramiko (pycrypto) dependency unable to install locally (probably missing some dependency). Will have a look. |
Updated .travis.yml to also run tests with Python 3.5 and merged those changes into trunk, thanks! P.S. I still have problems running tests under pypy locally (looks like an issue related to pycrypto on Fedora under pypy), but I went ahead and merged it since it passes on Travis. Thanks for those changes again - I didn't know tox supports this notation, it looks much better and there is less duplication now. |
Changes Unknown when pulling 9ce99b8 on ZuluPro:travis into ** on apache:trunk**. |
I've made real usage of travis' language parameter.
It ables to have the language column used in build summary (see https://travis-ci.org/ZuluPro/libcloud/builds/86103898)