Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clearer travis display & clean tox.ini #608

Closed
wants to merge 2 commits into from
Closed

Conversation

@ZuluPro
Copy link
Contributor

ZuluPro commented Oct 19, 2015

I've made real usage of travis' language parameter.
It ables to have the language column used in build summary (see https://travis-ci.org/ZuluPro/libcloud/builds/86103898)

ZuluPro added 2 commits Sep 18, 2015
before_script: TOX_ENV=lint
- python: 2.7
env: ENV=docs
before_script: TOX_ENV=docs

This comment has been minimized.

Copy link
@ZuluPro

ZuluPro Oct 19, 2015

Author Contributor

env is only used for display
before_script allows me to override value defined in install section.

tox.ini Outdated
deps = -r{toxinidir}/requirements-tests.txt
lockfile

[testenv:py34]
[testenv:py3.4]

This comment has been minimized.

Copy link
@ZuluPro

ZuluPro Oct 19, 2015

Author Contributor

I added . for match with $TRAVIS_PYTHON_VERSION.

@Kami
Copy link
Member

Kami commented Oct 19, 2015

Thanks.

I'm fine with that change, but it will break if Travis CI drops support for some Python version we still support, right?

In short - I'm fine with merging it, but we will need to revert this change in case Travis drops support for a Python version so we just need to document that - I guess we can just add a comment to the travis yaml file.

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Oct 19, 2015

it will break if Travis CI drops support for some Python version we still support, right?

No more things than before. We supports Python 2.5, have it in tox.ini, but can't test with Travis.

I guess we can just add a comment to the travis yaml file.

I'm doing...

@Kami
Copy link
Member

Kami commented Oct 20, 2015

@ZuluPro please let me know when you make those changes and I'll go ahead and merge this PR.

@Kami
Copy link
Member

Kami commented Nov 1, 2015

@ZuluPro Bump^

Would be great to get this addressed and merged.

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Nov 2, 2015

Sorry I'll do it tomorow !

@ZuluPro ZuluPro force-pushed the ZuluPro:travis branch 3 times, most recently from a507a08 to 62e855a Nov 2, 2015
@ZuluPro ZuluPro changed the title Make clearer travis display [wip] Make clearer travis display Nov 2, 2015
@ZuluPro ZuluPro force-pushed the ZuluPro:travis branch 11 times, most recently from c4ec686 to 9ce99b8 Nov 2, 2015
@@ -1,52 +1,28 @@
[tox]
envlist = py25,py26,py27,pypy,py32,py33,py34,lint
setenv =
PIP_USE_MIRRORS=1

This comment has been minimized.

Copy link
@ZuluPro

ZuluPro Nov 2, 2015

Author Contributor

Not supported anymore: chnm/serendipomatic#158

backports.ssl_match_hostname
unittest2
lockfile
paramiko

This comment has been minimized.

Copy link
@ZuluPro

ZuluPro Nov 2, 2015

Author Contributor

All this deps are defined in setup.py

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Nov 2, 2015

Done !
I also factorized tox.ini and test it for ensure great Python version is used.

@ZuluPro ZuluPro changed the title [wip] Make clearer travis display Make clearer travis display & clean tox.ini Nov 2, 2015
@Kami
Copy link
Member

Kami commented Nov 8, 2015

@ZuluPro Thanks. Next time please mention my nickname, since if you are not replying to my comment, I don't get a notification.

As far as tox changes go, I get this error:

kami ~/w/lc/libcloud (git:trunk)$ tox
ERROR: unknown environment 'py3.5'

Is this functionality only available in newer versions of tox or is there something else going on?

@Kami
Copy link
Member

Kami commented Nov 8, 2015

Actually, ignore my last comment. I just noticed python3.5 is not defined in basepython =map. I will fix this.

@Kami
Copy link
Member

Kami commented Nov 8, 2015

There is also an issue with pypy

ERROR:   pypypy: could not install deps [-r/home/kami/w/lc/libcloud/requirements-tests.txt, lockfile, paramiko]; v = InvocationError('/home/kami/w/lc/libcloud/.tox/pypypy/bin/pip install --pre -r/home/kami/w/lc/libcloud/requirements-tests.txt lockfile paramiko (see /home/kami/w/lc/libcloud/.tox/pypypy/log/pypypy-1.log)', 1)

Looks like the issue is related to paramiko (pycrypto) dependency unable to install locally (probably missing some dependency). Will have a look.

@asfgit asfgit closed this in 04a305a Nov 8, 2015
@Kami
Copy link
Member

Kami commented Nov 8, 2015

Updated .travis.yml to also run tests with Python 3.5 and merged those changes into trunk, thanks!

P.S. I still have problems running tests under pypy locally (looks like an issue related to pycrypto on Fedora under pypy), but I went ahead and merged it since it passes on Travis.

Thanks for those changes again - I didn't know tox supports this notation, it looks much better and there is less duplication now.

@coveralls
Copy link

coveralls commented Aug 31, 2017

Coverage Status

Changes Unknown when pulling 9ce99b8 on ZuluPro:travis into ** on apache:trunk**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.