Make clearer travis display & clean tox.ini #608

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@ZuluPro
Contributor

ZuluPro commented Oct 19, 2015

I've made real usage of travis' language parameter.
It ables to have the language column used in build summary (see https://travis-ci.org/ZuluPro/libcloud/builds/86103898)

+ before_script: TOX_ENV=lint
+ - python: 2.7
+ env: ENV=docs
+ before_script: TOX_ENV=docs

This comment has been minimized.

@ZuluPro

ZuluPro Oct 19, 2015

Contributor

env is only used for display
before_script allows me to override value defined in install section.

@ZuluPro

ZuluPro Oct 19, 2015

Contributor

env is only used for display
before_script allows me to override value defined in install section.

tox.ini
deps = -r{toxinidir}/requirements-tests.txt
lockfile
-[testenv:py34]
+[testenv:py3.4]

This comment has been minimized.

@ZuluPro

ZuluPro Oct 19, 2015

Contributor

I added . for match with $TRAVIS_PYTHON_VERSION.

@ZuluPro

ZuluPro Oct 19, 2015

Contributor

I added . for match with $TRAVIS_PYTHON_VERSION.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 19, 2015

Member

Thanks.

I'm fine with that change, but it will break if Travis CI drops support for some Python version we still support, right?

In short - I'm fine with merging it, but we will need to revert this change in case Travis drops support for a Python version so we just need to document that - I guess we can just add a comment to the travis yaml file.

Member

Kami commented Oct 19, 2015

Thanks.

I'm fine with that change, but it will break if Travis CI drops support for some Python version we still support, right?

In short - I'm fine with merging it, but we will need to revert this change in case Travis drops support for a Python version so we just need to document that - I guess we can just add a comment to the travis yaml file.

@ZuluPro

This comment has been minimized.

Show comment
Hide comment
@ZuluPro

ZuluPro Oct 19, 2015

Contributor

it will break if Travis CI drops support for some Python version we still support, right?

No more things than before. We supports Python 2.5, have it in tox.ini, but can't test with Travis.

I guess we can just add a comment to the travis yaml file.

I'm doing...

Contributor

ZuluPro commented Oct 19, 2015

it will break if Travis CI drops support for some Python version we still support, right?

No more things than before. We supports Python 2.5, have it in tox.ini, but can't test with Travis.

I guess we can just add a comment to the travis yaml file.

I'm doing...

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 20, 2015

Member

@ZuluPro please let me know when you make those changes and I'll go ahead and merge this PR.

Member

Kami commented Oct 20, 2015

@ZuluPro please let me know when you make those changes and I'll go ahead and merge this PR.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 1, 2015

Member

@ZuluPro Bump^

Would be great to get this addressed and merged.

Member

Kami commented Nov 1, 2015

@ZuluPro Bump^

Would be great to get this addressed and merged.

@ZuluPro

This comment has been minimized.

Show comment
Hide comment
@ZuluPro

ZuluPro Nov 2, 2015

Contributor

Sorry I'll do it tomorow !

Contributor

ZuluPro commented Nov 2, 2015

Sorry I'll do it tomorow !

@ZuluPro ZuluPro changed the title from Make clearer travis display to [wip] Make clearer travis display Nov 2, 2015

@@ -1,52 +1,28 @@
[tox]
-envlist = py25,py26,py27,pypy,py32,py33,py34,lint
-setenv =
- PIP_USE_MIRRORS=1

This comment has been minimized.

@ZuluPro

ZuluPro Nov 2, 2015

Contributor

Not supported anymore: chnm/serendipomatic#158

@ZuluPro

ZuluPro Nov 2, 2015

Contributor

Not supported anymore: chnm/serendipomatic#158

- backports.ssl_match_hostname
- unittest2
- lockfile
- paramiko

This comment has been minimized.

@ZuluPro

ZuluPro Nov 2, 2015

Contributor

All this deps are defined in setup.py

@ZuluPro

ZuluPro Nov 2, 2015

Contributor

All this deps are defined in setup.py

@ZuluPro

This comment has been minimized.

Show comment
Hide comment
@ZuluPro

ZuluPro Nov 2, 2015

Contributor

Done !
I also factorized tox.ini and test it for ensure great Python version is used.

Contributor

ZuluPro commented Nov 2, 2015

Done !
I also factorized tox.ini and test it for ensure great Python version is used.

@ZuluPro ZuluPro changed the title from [wip] Make clearer travis display to Make clearer travis display & clean tox.ini Nov 2, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 8, 2015

Member

@ZuluPro Thanks. Next time please mention my nickname, since if you are not replying to my comment, I don't get a notification.

As far as tox changes go, I get this error:

kami ~/w/lc/libcloud (git:trunk)$ tox
ERROR: unknown environment 'py3.5'

Is this functionality only available in newer versions of tox or is there something else going on?

Member

Kami commented Nov 8, 2015

@ZuluPro Thanks. Next time please mention my nickname, since if you are not replying to my comment, I don't get a notification.

As far as tox changes go, I get this error:

kami ~/w/lc/libcloud (git:trunk)$ tox
ERROR: unknown environment 'py3.5'

Is this functionality only available in newer versions of tox or is there something else going on?

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 8, 2015

Member

Actually, ignore my last comment. I just noticed python3.5 is not defined in basepython =map. I will fix this.

Member

Kami commented Nov 8, 2015

Actually, ignore my last comment. I just noticed python3.5 is not defined in basepython =map. I will fix this.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 8, 2015

Member

There is also an issue with pypy

ERROR:   pypypy: could not install deps [-r/home/kami/w/lc/libcloud/requirements-tests.txt, lockfile, paramiko]; v = InvocationError('/home/kami/w/lc/libcloud/.tox/pypypy/bin/pip install --pre -r/home/kami/w/lc/libcloud/requirements-tests.txt lockfile paramiko (see /home/kami/w/lc/libcloud/.tox/pypypy/log/pypypy-1.log)', 1)

Looks like the issue is related to paramiko (pycrypto) dependency unable to install locally (probably missing some dependency). Will have a look.

Member

Kami commented Nov 8, 2015

There is also an issue with pypy

ERROR:   pypypy: could not install deps [-r/home/kami/w/lc/libcloud/requirements-tests.txt, lockfile, paramiko]; v = InvocationError('/home/kami/w/lc/libcloud/.tox/pypypy/bin/pip install --pre -r/home/kami/w/lc/libcloud/requirements-tests.txt lockfile paramiko (see /home/kami/w/lc/libcloud/.tox/pypypy/log/pypypy-1.log)', 1)

Looks like the issue is related to paramiko (pycrypto) dependency unable to install locally (probably missing some dependency). Will have a look.

@asfgit asfgit closed this in 04a305a Nov 8, 2015

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Nov 8, 2015

Member

Updated .travis.yml to also run tests with Python 3.5 and merged those changes into trunk, thanks!

P.S. I still have problems running tests under pypy locally (looks like an issue related to pycrypto on Fedora under pypy), but I went ahead and merged it since it passes on Travis.

Thanks for those changes again - I didn't know tox supports this notation, it looks much better and there is less duplication now.

Member

Kami commented Nov 8, 2015

Updated .travis.yml to also run tests with Python 3.5 and merged those changes into trunk, thanks!

P.S. I still have problems running tests under pypy locally (looks like an issue related to pycrypto on Fedora under pypy), but I went ahead and merged it since it passes on Travis.

Thanks for those changes again - I didn't know tox supports this notation, it looks much better and there is less duplication now.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 31, 2017

Coverage Status

Changes Unknown when pulling 9ce99b8 on ZuluPro:travis into ** on apache:trunk**.

Coverage Status

Changes Unknown when pulling 9ce99b8 on ZuluPro:travis into ** on apache:trunk**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment