Skip to content

Make clearer travis display & clean tox.ini#608

Closed
ZuluPro wants to merge 2 commits intoapache:trunkfrom
ZuluPro:travis
Closed

Make clearer travis display & clean tox.ini#608
ZuluPro wants to merge 2 commits intoapache:trunkfrom
ZuluPro:travis

Conversation

@ZuluPro
Copy link
Contributor

@ZuluPro ZuluPro commented Oct 19, 2015

I've made real usage of travis' language parameter.
It ables to have the language column used in build summary (see https://travis-ci.org/ZuluPro/libcloud/builds/86103898)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env is only used for display
before_script allows me to override value defined in install section.

@Kami
Copy link
Member

Kami commented Oct 19, 2015

Thanks.

I'm fine with that change, but it will break if Travis CI drops support for some Python version we still support, right?

In short - I'm fine with merging it, but we will need to revert this change in case Travis drops support for a Python version so we just need to document that - I guess we can just add a comment to the travis yaml file.

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Oct 19, 2015

it will break if Travis CI drops support for some Python version we still support, right?

No more things than before. We supports Python 2.5, have it in tox.ini, but can't test with Travis.

I guess we can just add a comment to the travis yaml file.

I'm doing...

@Kami
Copy link
Member

Kami commented Oct 20, 2015

@ZuluPro please let me know when you make those changes and I'll go ahead and merge this PR.

@Kami
Copy link
Member

Kami commented Nov 1, 2015

@ZuluPro Bump^

Would be great to get this addressed and merged.

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Nov 2, 2015

Sorry I'll do it tomorow !

@ZuluPro ZuluPro force-pushed the travis branch 3 times, most recently from a507a08 to 62e855a Compare November 2, 2015 12:20
@ZuluPro ZuluPro changed the title Make clearer travis display [wip] Make clearer travis display Nov 2, 2015
@ZuluPro ZuluPro force-pushed the travis branch 11 times, most recently from c4ec686 to 9ce99b8 Compare November 2, 2015 14:41
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported anymore: chnm/serendipomatic#158

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Nov 2, 2015

Done !
I also factorized tox.ini and test it for ensure great Python version is used.

@ZuluPro ZuluPro changed the title [wip] Make clearer travis display Make clearer travis display & clean tox.ini Nov 2, 2015
@Kami
Copy link
Member

Kami commented Nov 8, 2015

@ZuluPro Thanks. Next time please mention my nickname, since if you are not replying to my comment, I don't get a notification.

As far as tox changes go, I get this error:

kami ~/w/lc/libcloud (git:trunk)$ tox
ERROR: unknown environment 'py3.5'

Is this functionality only available in newer versions of tox or is there something else going on?

@Kami
Copy link
Member

Kami commented Nov 8, 2015

Actually, ignore my last comment. I just noticed python3.5 is not defined in basepython =map. I will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants