[LIBCLOUD-766] Unique node.public_ips returned by CloudStack ex_get_nodes and list_nodes #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The change looks good to me, but I will wait on @Runseb or someone else with more CloudStack experience :) |
| @@ -4652,7 +4652,8 @@ def _to_node(self, data, public_ips=None): | |||
| extra['tags'] = self._get_resource_tags(data['tags']) | |||
|
|
|||
| node = CloudStackNode(id=id, name=name, state=state, | |||
| public_ips=public_ips, private_ips=private_ips, | |||
| public_ips=list(set(public_ips)), | |||
There was a problem hiding this comment.
Just curious - so the issue only exists for public, but not private ips?
There was a problem hiding this comment.
The issue only exists for public ips because private ips are not passed with argument.
The issue occurs when an ip is included in both data['nic'] and argument public_ips.
|
Would appreciate if you can sync this branch with latest trunk so I can apply patch directly (I've merged 767 first and now there are conflicts). |
…ode and list_nodes
atsaki
force-pushed
the
766_unique_node_public_ips
branch
from
996ec1b
to
ab5d095
Compare
|
I rebased the branch to the latest trunk. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue node's public_ips have duplicate values.
https://issues.apache.org/jira/browse/LIBCLOUD-766