Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-775 Update node, update VMware tools, add storage, change st… #644



Copy link

…orage size or speed, remove storage. With tests

…orage size or speed, remove storage. With tests

def ex_change_storage_speed(self, node, disk_id, speed):
Remove storage from a node
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this comment needs to be updated :)

Copy link

Kami commented Dec 2, 2015

Added some comments for future improvements (not a blocker for this PR, you can address them in a future PR).

Besides that, LGTM, +1.

Please also make sure you update changelog.

Copy link
Contributor Author

Will update CHANGES.rst separately since I had a couple of other closed PRs anyway.

@asfgit asfgit closed this in 36ed630 Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants