LIBCLOUD-775 Update node, update VMware tools, add storage, change st… #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orage size or speed, remove storage. With tests
|
|
||
| def ex_change_storage_speed(self, node, disk_id, speed): | ||
| """ | ||
| Remove storage from a node |
There was a problem hiding this comment.
I believe this comment needs to be updated :)
|
Added some comments for future improvements (not a blocker for this PR, you can address them in a future PR). Besides that, LGTM, +1. Please also make sure you update changelog. |
|
Will update CHANGES.rst separately since I had a couple of other closed PRs anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…orage size or speed, remove storage. With tests