auroradns: Properly parse TTL as extra data #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm but I don't have a commit bit, so someone else will need to check it. |
|
Good catch :) Test would also be nice. |
|
I agree @Kami, a test would indeed be a good thing :) |
|
I just added a Unit Test to verify this case. I'll add more later in a different PR |
| AuroraDNSDriverMockHttp.type = None | ||
| self.driver = AuroraDNSDriver(*DNS_PARAMS_AURORADNS) | ||
|
|
||
| def test_merge_extra_data(self): |
There was a problem hiding this comment.
I was more thinking about adding a test case which uses response fixture, but that works for now.
|
Tests are failing (https://travis-ci.org/apache/libcloud/jobs/101036033), need to add aurora params to |
wido
force-pushed
the
auroradns-ttl-fix
branch
2 times, most recently
from
1a3ad13 to
9a747d3
Compare
Small typo in the list caused this not to be parsed properly
|
Fixed! Tests are no longer failing. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small typo in the list caused this not to be parsed properly.