Throw a more friendly error message if establishing SSL / TLS connection fails #682
Conversation
libcloud/httplib_ssl.py
Outdated
cert_reqs=ssl.CERT_REQUIRED, | ||
ca_certs=self.ca_cert, | ||
ssl_version=libcloud.security.SSL_VERSION) | ||
except Exception: |
jimbobhickville
Jan 14, 2016
Contributor
Shouldn't we limit this to the specific exception type(s) that might exhibit this behavior? Looked like it was socket.error
in the JIRA.
Shouldn't we limit this to the specific exception type(s) that might exhibit this behavior? Looked like it was socket.error
in the JIRA.
Kami
Jan 14, 2016
Author
Member
Yeah, that's a good idea - I will make that change.
Yeah, that's a good idea - I will make that change.
Kami
Jan 14, 2016
Author
Member
Done.
Also committed some tests (previously I forgot to add the test file).
Done.
Also committed some tests (previously I forgot to add the test file).
… and message. Make sure we also handle that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
With this change we now throw a more user-friendly error message in case establishing SSL / TLS connection fails.
New error message:
Related to https://issues.apache.org/jira/browse/LIBCLOUD-791