Skip to content

Add Rackspace Cloud Files TempURL support#72

Closed
shawnps wants to merge 25 commits into
apache:trunkfrom
shawnps:cloudfiles_ex_get_temp_url
Closed

Add Rackspace Cloud Files TempURL support#72
shawnps wants to merge 25 commits into
apache:trunkfrom
shawnps:cloudfiles_ex_get_temp_url

Conversation

@shawnps
Copy link
Copy Markdown

@shawnps shawnps commented Aug 7, 2012

No description provided.

Comment thread libcloud/storage/drivers/cloudfiles.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the docs (http://docs.rackspace.com/files/api/v1/cf-devguide/content/Create_TempURL-d1a444.html), you also need to specify an object prefix when creating a temp URL for a container.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, yeah. That's only for PUTs though, right? And I don't see where the prefix goes, is it a query param?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, documentation isn't totally cleared - would need to check the code.

Comment thread libcloud/storage/drivers/cloudfiles.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style bike shed: use single quotes

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread libcloud/storage/drivers/cloudfiles.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRC, the correct Pythonic way is doing except Exception:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…_ex_get_object_temp_url_no_key_raises_key_error
Comment thread libcloud/storage/drivers/cloudfiles.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use libcloud.utils.py3.urlencode.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants