Add Rackspace Cloud Files TempURL support #72
Conversation
…urned metadata dictionary
| return response.status in [httplib.OK, httplib.NO_CONTENT, | ||
| httplib.CREATED, httplib.ACCEPTED] | ||
|
|
||
| def ex_get_container_temp_url(self, container, method, timeout=60): |
There was a problem hiding this comment.
Look at the docs (http://docs.rackspace.com/files/api/v1/cf-devguide/content/Create_TempURL-d1a444.html), you also need to specify an object prefix when creating a temp URL for a container.
There was a problem hiding this comment.
I saw that, yeah. That's only for PUTs though, right? And I don't see where the prefix goes, is it a query param?
There was a problem hiding this comment.
Not sure, documentation isn't totally cleared - would need to check the code.
| Cloud Files account using \ | ||
| ex_set_account_metadata_temp_url_key before \ | ||
| you can use this method.") | ||
| hmac_body = "%s\n%s\n%s" % (method, expires, path) |
| try: | ||
| key = self.ex_get_meta_data()['temp_url_key'] | ||
| assert key is not None | ||
| except: |
There was a problem hiding this comment.
IRC, the correct Pythonic way is doing except Exception:
…_ex_get_object_temp_url_no_key_raises_key_error
|
|
||
| from libcloud.utils.py3 import httplib | ||
| from libcloud.utils.py3 import urllib |
There was a problem hiding this comment.
You should use libcloud.utils.py3.urlencode.
| container=container, meta_data=None, | ||
| driver=self) | ||
| exception_string = 'You must first set the X-Account-Meta-Temp-URL-Key header on your Cloud Files account using ex_set_account_metadata_temp_url_key before you can use this method.' | ||
| with self.assertRaisesRegexp(KeyError, exception_string): |
There was a problem hiding this comment.
That's not available in version < 2.7 so you can't do that.
|
Thanks. Merged into trunk (http://svn.apache.org/viewvc?view=revision&revision=1370664) with some changes:
|
|
This has been merged, can you please close this PR? |
No description provided.