Added location filter in list_nodes of CloudStack #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1348,7 +1348,7 @@ def list_locations(self): | |||
|
|
|||
| return locations | |||
|
|
|||
| def list_nodes(self, project=None): | |||
| def list_nodes(self, project=None, location=None): | |||
There was a problem hiding this comment.
It looks like we missed this while merging the original changes - project should really be prefixed with ex_ since it's not part of the standard API.
In any case, I'm fine with this for now.
|
Thanks. As noted in the in-line comment, change looks good to me, but it would also be great if you can add a test case for it :) |
|
Ok, I will add a test case. |
|
I merged this change into trunk. Please follow up with tests as soon as you can. Thanks! |
|
@Kami: I added a test. Should I create a new PR since this one is already merged ? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.