Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libvirt/include sasl auth #809

Closed

Conversation

Katana-Steel
Copy link
Contributor

@Katana-Steel Katana-Steel commented Jun 9, 2016

include sasl auth to libvirt_driver

Description

Adding SASL authentication to QEMU+tcp remote connections

Because this really annoyed me. We have about +100 KVM servers and I'd
just to iterate over them and get all the available nodes. Apply a few filters
and then return a list of nodes where the end user don't need to worry about
which KVM host his VM is running on and just be able to reboot it should he
need to.

Status

  • work in progress

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@Katana-Steel Katana-Steel force-pushed the libvirt/include_sasl_auth branch 2 times, most recently from 4b4bf8d to 3adf5f6 Compare June 9, 2016 07:17
@Kami
Copy link
Member

Kami commented Jun 9, 2016

Awesome, thanks.

I will look into it ASAP.

inlude sasl auth for uri='qemu+tcp://<host>/system' to provide
access to remote libvirtd servers providing user and pass
authentication.
updated the constructor documentation and added description for
the callback function.
except libvirt.libvirtError:
if key is None or secret is None:
raise RuntimeError('The remote Libvirt instance requires ' +
'authenication, please set \'key\' and ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@tonybaloney
Copy link
Contributor

👍

@asfgit asfgit closed this in 00b70ef Jun 24, 2016
asfgit pushed a commit that referenced this pull request Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants