Docker bug fixes #821
Merged
Docker bug fixes #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👍 And yeah, hopefully including version in the URL will allow us to keep the driver a bit more sane and not break when new docker (API) version is released. Down the road, we also need decide if we should (does it make sense, maybe it's too much overhead, etc.) to support multiple API versions. Maybe we should only do it for major versions or similar. |
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes for the Docker driver
The docker driver was initially tested on v1.21 (1.9.x), Docker API supports versioning in the URI path now. I've updated the tests with 2 sets of fixtures, the 1.21 and the 1.24 (latest) API.
For more information on contributing, please see Contributing
section of our documentation.
Status
Replace this: describe the PR status. Examples:
Checklist (tick everything that applies)