New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker bug fixes #821

Merged
merged 5 commits into from Jun 25, 2016

Conversation

Projects
None yet
3 participants
@tonybaloney
Contributor

tonybaloney commented Jun 24, 2016

Bug fixes for the Docker driver

The docker driver was initially tested on v1.21 (1.9.x), Docker API supports versioning in the URI path now. I've updated the tests with 2 sets of fixtures, the 1.21 and the 1.24 (latest) API.

For more information on contributing, please see Contributing
section of our documentation.

Status

Replace this: describe the PR status. Examples:

  • work in progress
  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 25, 2016

Member

Nice 👍

And yeah, hopefully including version in the URL will allow us to keep the driver a bit more sane and not break when new docker (API) version is released.

Down the road, we also need decide if we should (does it make sense, maybe it's too much overhead, etc.) to support multiple API versions. Maybe we should only do it for major versions or similar.

Member

Kami commented Jun 25, 2016

Nice 👍

And yeah, hopefully including version in the URL will allow us to keep the driver a bit more sane and not break when new docker (API) version is released.

Down the road, we also need decide if we should (does it make sense, maybe it's too much overhead, etc.) to support multiple API versions. Maybe we should only do it for major versions or similar.

@asfgit asfgit merged commit a99601a into apache:trunk Jun 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

asfgit pushed a commit that referenced this pull request Jun 25, 2016

asfgit pushed a commit that referenced this pull request Jun 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment