Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-2910]Fix web build of LICENSE text #2911

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

casionone
Copy link
Contributor

@casionone casionone commented Aug 20, 2022

What is the purpose of the change

EngineConn-Core defines the the abstractions and interfaces of the EngineConn core functions.
The Engine Service in Linkis 0.x is refactored, EngineConn will handle the engine connection
and session management.

Related issues/PRs

Related issues:-

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@casionone casionone changed the title fix web build of LICENSE text [ISSUE-2910]Fix web build of LICENSE text Aug 20, 2022
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #2911 (2ac2aee) into dev-1.2.0 (6e09b1b) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-1.2.0    #2911   +/-   ##
============================================
  Coverage        14.68%   14.68%           
  Complexity        1162     1162           
============================================
  Files              741      741           
  Lines            23205    23205           
  Branches          3436     3436           
============================================
  Hits              3407     3407           
  Misses           19335    19335           
  Partials           463      463           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 70f71d1 into apache:dev-1.2.0 Aug 20, 2022
@casionone casionone deleted the release-1.2.0-FIX branch September 3, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants