Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL Password in configuration file Rule False Positives #105

Merged
merged 1 commit into from Feb 9, 2024

Conversation

justinmichaels
Copy link
Contributor

CodeQL is falsly identifying the documentation examples of SQL Server connection strings violating CodeQL: c# Password in configuration file Rule. Even though it's a false positive, many organizations take stances of not allowing dismissals and would rather see fixes for CodeQL findings. This proposed change will prevent this rule from being tripped in the future and not require organizations to mark these as false positives manually.

…deQL rule id cs/password-in-configuration false positive
Copy link
Contributor

@FreeAndNil FreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FreeAndNil FreeAndNil merged commit 2a013ea into apache:master Feb 9, 2024
@FreeAndNil FreeAndNil added this to the 2.0.16 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants