Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 4 of nullable and modernization #129

Conversation

erikmav
Copy link
Contributor

@erikmav erikmav commented Mar 20, 2024

For #124

@FreeAndNil FreeAndNil changed the base branch from master to Feature/111-Dropping-support-for-older-runtimes March 20, 2024 16:38
@apache apache deleted a comment from erikmav Mar 20, 2024
Copy link
Contributor

@FreeAndNil FreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Just some nits and missing tests.
I've documented the breaking changes in #124

src/log4net/Appender/AppenderCollection.cs Outdated Show resolved Hide resolved
src/log4net/Appender/AppenderCollection.cs Outdated Show resolved Hide resolved
src/log4net/Appender/BufferingAppenderSkeleton.cs Outdated Show resolved Hide resolved
src/log4net/Appender/BufferingAppenderSkeleton.cs Outdated Show resolved Hide resolved
src/log4net/Appender/BufferingAppenderSkeleton.cs Outdated Show resolved Hide resolved
src/log4net/Core/LogImpl.cs Show resolved Hide resolved
src/log4net/Core/StackFrameItem.cs Outdated Show resolved Hide resolved
src/log4net/Core/StackFrameItem.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@FreeAndNil FreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erik. Just one question regarding the test.

Copy link
Contributor

@FreeAndNil FreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@FreeAndNil FreeAndNil merged commit 1115813 into apache:Feature/111-Dropping-support-for-older-runtimes Mar 22, 2024
@erikmav erikmav deleted the dev/erikmav/nullableAndModernization4 branch March 25, 2024 15:28
FreeAndNil added a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants