Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the event properties in CreateCompositeProperties #5

Closed
wants to merge 1 commit into from

Conversation

dpsenner
Copy link
Member

@dpsenner dpsenner commented Jun 8, 2017

In order to increase the speed up operations in almost x10 times of using properties in the output when UserName and Identity information are not needed.

In order to increase the speed up operations in almost x10 times of using properties in the output when UserName and Identity information are not needed.
@dpsenner
Copy link
Member Author

dpsenner commented Jun 8, 2017

There is an issue for this too (LOG4NET-429).

@dpsenner
Copy link
Member Author

dpsenner commented Jun 8, 2017

The patches available as attachments on issue LOG4NET-429 look more sensible to me. This patch simply removes this feature and thus breaks current behavior. In my eyes this is not a great deal.

@fluffynuts
Copy link
Contributor

Good day

It's been quite a while since this PR last saw activity. In an attempt to get pull requests under some semblance of
order, I'm having to make the uncomfortable decision to jettison pull requests which have been dormant for quite some
time. Perhaps arbitrarily, I'm choosing all pull requests which have not seen activity this year (2021), most of
which are marked as not building or have conflicts with the main branch.

This is not because the contributions aren't valuable - it's simply a matter of being the only person spending
some time on this and being a little overwhelmed. I'd rather get some traction on newer issues than continue
to try to understand, upgrade and work through PRs which don't build or which conflict with the main branch,
or which simply may have been solved in the mean time.

I encourage you to re-submit the PR against the current main branch if the issue is still significant. Your
contributions are appreciated. I apologise for any inconvenience caused and sincerely hope that you understand
the constraints involved which have brought me to the place of making this decision.

@fluffynuts fluffynuts closed this Oct 25, 2021
@fluffynuts fluffynuts deleted the pr/old/28 branch November 2, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants