Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9057 Fix issues to get site up to par with current prod #10

Merged
merged 21 commits into from
Jan 31, 2020

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Jan 31, 2020

https://issues.apache.org/jira/browse/LUCENE-9057

This invalidates #9 which had a messy git history

Here is an attempt to bring the new site up to date with current svn.

I have committed each svn commit separately onto this PR, and attributed with the original committers's id. I tried to fix the dates to the svn dates but could only do that for some commits.

Then there are some commits to fix various broken things such as bad links, outdated content, wiki links etc.

I am not quite sure why this PR appears to repeat some commits that are already in master branch (like "adding latest committers" by Houston and "manually trigger build" by Uwe). I think it may be because my local branch was not fully up to date with asf master before I started backporting from SVN, so I had to merge in those changes afterwards. This gives a bit messy history but I think the end result is ok.

There is still some work to do

The news pages show top N news, there should be some paging or "show all"
We still link to git-wip and call GitHub a "mirror"
Other

janhoy and others added 18 commits January 31, 2020 10:35
From svn commit 1869809 by namgyu 2019-11-14 18:56
From svn commit 1869810 by namgyu 2019-11-14 19:03
From svn commit 1869961 by janhoy 2019-11-18 09:37
From of svn commit 1869972 by janhoy 2019-11-18 14:31
…oving "Community" section which was moved way back

Including update from svn commit 1870033 by ctargett 2019-11-19 23:01
Remove reference to PDF format Ref Guide
From svn commit 1870091 by ctargett 2019-11-21 16:28
From svn rev 1870748 Committed by jpountz 03/12/2019, 11:17
From svn rev 1870790 by ishan at 2019-12-04 05:26
From svn rev 1871148 by broustant at 2019-12-10 20:51
From svn rev 1872087 by jpountz at 2019-12-29 20:48
From svn rev 1872778 by ishan at 2020-01-14 14:07
@uschindler
Copy link
Contributor

Could you also update version numbers in the htaccess file? You can't backport this, but it's needed to have redirects working correctly.

I am also not sure about some absolute urls introduced. Can we not simply remove them? The page should never ever refer to lucene.apache.org directly.

Otherwise looks good.

@janhoy janhoy closed this Jan 31, 2020
@janhoy janhoy reopened this Jan 31, 2020
@janhoy
Copy link
Contributor Author

janhoy commented Jan 31, 2020

Could you also update version numbers in the htaccess file? You can't backport this, but it's needed to have redirects working correctly.

Done

I am also not sure about some absolute urls introduced. Can we not simply remove them? The page should never ever refer to lucene.apache.org directly.

Will have a look

@uschindler
Copy link
Contributor

uschindler commented Jan 31, 2020

Thanks. We should possibly have an automatism. pelican should be able to also apply variable substitution in non markdown. I will try to figure that out.

Uwe

@janhoy
Copy link
Contributor Author

janhoy commented Jan 31, 2020

I propose to merge this PR now and then to do followup fixes, ok?

@uschindler
Copy link
Contributor

Yes. Merge it.

@janhoy janhoy merged commit 9378b2f into apache:master Jan 31, 2020
@janhoy janhoy deleted the lucene9057-take2 branch January 31, 2020 10:16
@janhoy
Copy link
Contributor Author

janhoy commented Jan 31, 2020

Thanks for the review

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants