Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickable links #41

Merged
merged 3 commits into from
Feb 17, 2021
Merged

clickable links #41

merged 3 commits into from
Feb 17, 2021

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Feb 15, 2021

Make the community links on https://lucene.apache.org/solr/community.html#slack actually clickable!

Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I notice that the Slack URLs are to invite links. They assume you are not already a member, and if so you are not taken to the slack channel if you click. Should we have one direct link and another "sign up" link to make it clear?

epugh@opensourceconnections.com added 2 commits February 16, 2021 09:07
@epugh
Copy link
Contributor Author

epugh commented Feb 16, 2021

Looks good.
I notice that the Slack URLs are to invite links. They assume you are not already a member, and if so you are not taken to the slack channel if you click. Should we have one direct link and another "sign up" link to make it clear?

Done! I'm a bit nervous to merge these changes, do you want the honors of the merge?

@janhoy janhoy merged commit bee25b7 into master Feb 17, 2021
@janhoy
Copy link
Contributor

janhoy commented Feb 17, 2021

No prob, the changes will end up on https://lucene.staged.apache.org/solr/community.html#mailing-lists-irc first, so it is easy to check if it worked before merging to production branch. I just merged this, and looks good. I think still some minor cleanups to do, perhaps also add separate Slack and signup links for the othe channels. But Good for now. I'll create a merge to prod PR.

@janhoy janhoy deleted the make_community_links_clickable branch March 4, 2021 22:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants