Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Google Analytics from Lucene site #60

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Remove Google Analytics from Lucene site #60

merged 1 commit into from
Aug 31, 2021

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Aug 24, 2021

As done for Solr - get rid of GA script for Lucene site.

@janhoy
Copy link
Contributor Author

janhoy commented Aug 31, 2021

@msokolov please review if you want Lucene to be GA free :-)

uschindler
uschindler approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, it's basically the same like Solr.

@uschindler
Copy link
Contributor

(sorry for late reply)

@janhoy janhoy merged commit 0f0af22 into apache:main Aug 31, 2021
@janhoy janhoy deleted the remove-ga branch August 31, 2021 15:20
@msokolov
Copy link
Contributor

Thanks, Jan and Uwe!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uschindler uschindler uschindler approved these changes

@msokolov msokolov Awaiting requested review from msokolov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhoy @uschindler @msokolov