LUCENE-9141: Simplify LatLonShapeXQuery API. #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to support that.
# Conflicts: # lucene/core/src/java/org/apache/lucene/document/LatLonShapeLineQuery.java # lucene/core/src/java/org/apache/lucene/document/LatLonShapePointQuery.java # lucene/core/src/java/org/apache/lucene/document/LatLonShapePolygonQuery.java # lucene/sandbox/src/java/org/apache/lucene/document/LatLonShapeComponent2DQuery.java # lucene/sandbox/src/java/org/apache/lucene/document/LatLonShapePolygonQuery.java
|
Update the PR by making LatLonGeometry an abstract class so the method that return a Component2D can be made protected. |
nknize
approved these changes
Jan 29, 2020
|
|
||
| /** create a query to find all indexed geo shapes that intersect a provided geometry collection. | ||
| **/ | ||
| public static Query newGeometryCollectionQuery(String field, QueryRelation queryRelation, LatLonGeometry... latLonGeometries) { |
There was a problem hiding this comment.
nit: do you think we could just name this newGeometryQuery? This way we just treat geometries and single and/or collections? Feels a little less confusing IMHO.
There was a problem hiding this comment.
Yes, I think it is a better name
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2020
…class called LatLonGeometry. (#1170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to simplify the LatLonShape query API. The trick for this simplification is to introduce a new interface called
LatLonGeometrywhich is implemented by objects defining queryable geometries, that isPolygon,Lineand the newly introducedPoint.The main feature of those geometries is that they can return a
Component2Dobject that can be used for query the index.