Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation #1207

Merged
merged 1 commit into from Jan 24, 2020
Merged

LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation #1207

merged 1 commit into from Jan 24, 2020

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Jan 24, 2020

Description

This workflow validates the checksums of Gradle Wrapper JAR files present in the source tree and fails if unknown Gradle Wrapper JAR files are found.

Solution

See https://github.com/marketplace/actions/gradle-wrapper-validation

Tests

N/A

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.

Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you.

@dweiss dweiss merged commit 24f7a28 into apache:master Jan 24, 2020
@janhoy
Copy link
Contributor

janhoy commented Jan 25, 2020

This workflow was triggered on a push to my fork (https://github.com/cominvent/lucene-solr/commit/9bae9c71ef632e141adedadc7ccfccabe2ca353d/checks?check_suite_id=419459737) and I got an error email. Can you disable for forks?

@eskatos eskatos deleted the eskatos/wrapper-validation-action branch January 25, 2020 10:13
@dweiss
Copy link
Contributor

dweiss commented Jan 25, 2020 via email

@eskatos
Copy link
Member Author

eskatos commented Jan 25, 2020

It's a free service. But Github organizations with legacy Github paid plans can't run Github Actions yet (they don't get free OSS minutes). I suppose cominvent has a legacy paid plan.

@eskatos
Copy link
Member Author

eskatos commented Jan 25, 2020

@janhoy, you can disable Github Actions on your fork, go to Settings > Actions and select Disable Actions for this repository

@eskatos
Copy link
Member Author

eskatos commented Jan 25, 2020

Also note that this isn't limited to this workflow. The existing .github/workflows/ant.yml caused the same issue on your fork 4 days ago. See https://github.com/cominvent/lucene-solr/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants