Add back assertions removed by LUCENE-9187. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time they would only apply to TestFastLZ4/TestHighLZ4 and avoid slowing down all tests.
|
I think the randomize() stuff in {{src/java}} is confusing to follow and does not belong there. maybe we should defer/split that and just get the assertion working again? It seems enough to add back the assertReset, but only call it from AssertingHashTable like you did here? |
|
+1, thanks |
jpountz
added a commit
that referenced
this pull request
Feb 14, 2020
This time they would only apply to TestFastLZ4/TestHighLZ4 and avoid slowing down all tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time they would only apply to TestFastLZ4/TestHighLZ4 and avoid slowing
down all tests.