Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-9244: In 2D, a point can be shared by four leaves #1279

Merged
merged 4 commits into from Apr 7, 2020
Merged

LUCENE-9244: In 2D, a point can be shared by four leaves #1279

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
372742e
In 2D, a point can be shred by four leaves
iverase Feb 24, 2020
2f59081
change > to >=
iverase Mar 2, 2020
70beb77
Merge branch 'master' into LUCENE-9244
iverase Apr 7, 2020
ba68c9c
Update CHANGES.txt
iverase Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions lucene/core/src/test/org/apache/lucene/codecs/lucene60/TestLucene60PointsFormat.java
View file
Open in desktop
Expand Up @@ -299,12 +299,13 @@ public Relation compare(byte[] minPackedValue, byte[] maxPackedValue) {
return Relation.CELL_CROSSES_QUERY;
}
};
// If only one point matches, then the point count is (actualMaxPointsInLeafNode + 1) / 2
// in general, or maybe 2x that if the point is a split value

final long pointCount = points.estimatePointCount(onePointMatchVisitor);
assertTrue(""+pointCount,
pointCount == (actualMaxPointsInLeafNode + 1) / 2 || // common case
pointCount == 2*((actualMaxPointsInLeafNode + 1) / 2)); // if the point is a split value
// The number of matches needs to be multiple of count per leaf
final long countPerLeaf = (actualMaxPointsInLeafNode + 1) / 2;
assertTrue(""+pointCount, pointCount % countPerLeaf == 0);
// in extreme cases, a point can be be shared by 4 leaves
assertTrue(""+pointCount, pointCount / countPerLeaf <= 4 && pointCount / countPerLeaf >= 1);

final long docCount = points.estimateDocCount(onePointMatchVisitor);
if (multiValues) {
Expand Down