LUCENE-9344: Convert XXX.txt files to proper XXX.md #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocobeta
commented
Apr 23, 2020
| @@ -66,7 +66,7 @@ system. | |||
|
|
|||
| NOTE: the ~ character represents your user account home directory. | |||
|
|
|||
| Step 3) Run ant | |||
| ## Step 4) Run ant | |||
There was a problem hiding this comment.
Actually it's step 4.
mocobeta
commented
Apr 23, 2020
| @@ -19,16 +19,16 @@ For reference, JRE major versions with their corresponding Unicode versions: | |||
| * Java 8, Unicode 6.2 | |||
| * Java 9, Unicode 8.0 | |||
|
|
|||
| In general, whether or not you need to re-index largely depends upon the data that | |||
| In general, whether you need to re-index largely depends upon the data that | |||
There was a problem hiding this comment.
My linter complained, so fixed the phrasing as it suggested; can be reverted.
mocobeta
commented
Apr 23, 2020
| of Unicode, you can safely ignore this. | ||
|
|
||
| ## Special Notes: LUCENE 2.9 TO 3.0, JAVA 1.4 TO JAVA 5 TRANSITION | ||
|
|
||
| * `StandardAnalyzer` will return the same results under Java 5 as it did under | ||
| Java 1.4. This is because it is largely independent of the runtime JRE for | ||
| Unicode support, (with the exception of lowercasing). However, no changes to | ||
| Unicode support, (except for lowercasing). However, no changes to |
There was a problem hiding this comment.
My linter complained, so fixed the phrasing as it suggested; can be reverted.
mocobeta
commented
Apr 23, 2020
| @@ -14,5 +14,5 @@ implementing Lucene (document size, number of documents, and number of | |||
| hits retrieved to name a few). The benchmarks page has some information | |||
| related to performance on particular platforms. | |||
|
|
|||
| *To build Apache Lucene from source, refer to the `BUILD.txt` file in | |||
| *To build Apache Lucene from the source, refer to the `BUILD.txt` file in | |||
There was a problem hiding this comment.
My linter complained, so fixed the phrasing as it suggested; can be reverted.
dsmiley
approved these changes
Apr 23, 2020
|
Thank you for reviewing, I just merge it on the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed README.txt, MIGRATE.txt, etc. to
.mdand partially fix its markdown formatting.LICENCE.txt and NOTICE.txt were not modified.
See https://issues.apache.org/jira/browse/LUCENE-9344
Tests
ant package-tgzincludes the all .md filesTODO: run smoke testThis passednightly-smoke