SOLR-14423: Use SolrClientCache instance managed by CoreContainer #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reContainer as much as possible (there are a few places in streaming and sql client classes that can't use it). This also adds a general-purpose ObjectCache to CoreContainer.
madrob
reviewed
May 5, 2020
solr/core/src/java/org/apache/solr/handler/sql/CalciteSolrDriver.java
Outdated
Show resolved
Hide resolved
cpoerschke
reviewed
May 6, 2020
solr/core/src/java/org/apache/solr/handler/sql/CalciteSolrDriver.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/metrics/reporters/solr/SolrReporter.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
May 12, 2020
| static ModelCache modelCache = null; | ||
| static ConcurrentMap objectCache = new ConcurrentHashMap(); | ||
| private ModelCache modelCache = null; | ||
| private ConcurrentMap objectCache = new ConcurrentHashMap(); |
There was a problem hiding this comment.
Glad to see the removal of nasty statically declared caches!
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Does your IDE have a template generating these? I recommend disabling.
dsmiley
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Jira for more details.