SOLR-14494: Refactor BlockJoin to not use Filter #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhludnev
approved these changes
May 17, 2020
|
Just checking -- you have no concerns my simplification of use of the cache, and caching the BitSetProducer as the value instead of some Filter/Query wrapper? And I'm thinking just 9x only, although backporting wouldn't be a big deal. |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2020
Note: henceforth the perSegFilter cache will internally have values of type BitSetProducer instead of Filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14494
In this PR I may have over-reached the refactorings beyond the scope a bit; it could be scaled back. I didn't get why the cache interaction was as complex as it was so I simplified it but I may be wrong on this.
CC @mkhludnev