SOLR-14443: Make SolrLogPostTool resilient to odd requests #1525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SolrLogPostTool is relatively brittle in how it indexes log records to Solr. A single error from Solr causes the tool to crash. Further, when user requests have duplicate or unnecessary parameters, the tool attempts to record all of these (even when the field used is singlevalued).
As a result, a single "oddball" request crashes the whole ingestion run.
Solution
This PR makes two related changes. First, it changes SolrLogPostTool's batching code to log (but ultimately ignore) errors. This allows an indexing run to survive malformed records or other indexing blips. Second, it changes the record-parsing code to only record single values for single-valued log record fields. This prevents a common cause of malformed records.
Tests
Manual testing, in addition to a test case added to SolrLogPostToolTest
Checklist
Please review the following and check all that apply:
master
branch.ant precommit
and the appropriate test suite.