Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-9365 FuzzyQuery false negative #1545

Merged
merged 1 commit into from Jun 3, 2020
Merged

LUCENE-9365 FuzzyQuery false negative #1545

merged 1 commit into from Jun 3, 2020

Conversation

madrob
Copy link
Contributor

@madrob madrob commented May 29, 2020

when prefix length == search term length

Co-Authored-By: markharwood markharwood@gmail.com

@madrob madrob requested a review from markharwood May 29, 2020 15:26
markharwood
markharwood reviewed May 29, 2020
View reviewed changes
Copy link
Contributor

@markharwood markharwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, @madrob.

Just a couple of comments otherwise LGTM

  • The precommit looks to be failing with an unused import
  • Does the test code need the extra test you suggested here?

@madrob @markharwood
LUCENE-9365 FuzzyQuery false negative when prefix length == search te…
ef309ad 
…rm length

Co-Authored-By: markharwood <markharwood@gmail.com>
@madrob madrob merged commit 45611d0 into apache:master Jun 3, 2020
@madrob madrob deleted the fuzzyprefix branch June 3, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markharwood markharwood markharwood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@madrob @markharwood