Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9391: Upgrade HPPC to 0.8.2 #1560

Merged
merged 3 commits into from
Jun 12, 2020
Merged

LUCENE-9391: Upgrade HPPC to 0.8.2 #1560

merged 3 commits into from
Jun 12, 2020

Conversation

zhaih
Copy link
Contributor

@zhaih zhaih commented Jun 9, 2020

Description

Upgrade HPPC to 0.8.2
ant test passed
ant precommit passed

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ant precommit and the appropriate test suite.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

@dweiss
Copy link
Contributor

dweiss commented Jun 10, 2020

Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and Lucene, I guess) and attribution to your name? Otherwise LGTM.

@@ -10,7 +10,7 @@ com.carrotsearch.randomizedtesting.version = 2.7.6

/com.carrotsearch.thirdparty/simple-xml-safe = 2.7.1

/com.carrotsearch/hppc = 0.8.1
/com.carrotsearch/hppc = 0.8.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this then mean that Lucene's facet module's usage of HPPC is upgraded too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so? In facet's ivy.xml it use rev="${/com.carrotsearch/hppc}" which I believe is the variable here.

@zhaih
Copy link
Contributor Author

zhaih commented Jun 11, 2020

Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and Lucene, I guess) and attribution to your name? Otherwise LGTM.

Thanks for reminding me that! Added!

@danmuzi
Copy link
Member

danmuzi commented Jun 11, 2020

Hi Patrick,
Thanks for your contribution 👍
I found the JIRA-issue number of this PR is wrong.
It should be changed from [LUCENE-8574] to [LUCENE-9391].
https://issues.apache.org/jira/browse/LUCENE-9391
Please check it.

@zhaih zhaih changed the title LUCENE-8574: Upgrade HPPC to 0.8.2 LUCENE-9391: Upgrade HPPC to 0.8.2 Jun 11, 2020
@zhaih
Copy link
Contributor Author

zhaih commented Jun 11, 2020

Hi Patrick,
Thanks for your contribution 👍
I found the JIRA-issue number of this PR is wrong.
It should be changed from [LUCENE-8574] to [LUCENE-9391].
https://issues.apache.org/jira/browse/LUCENE-9391
Please check it.

Oh, thank you for figuring that out! Yeah I picked up a wrong one from my backlog... Thank you very much!

@zhaih
Copy link
Contributor Author

zhaih commented Jun 11, 2020

Do I need to squash the commits? Seems commits in Lucene are all squashed? Or it will be done automatically when merging somehow?

@danmuzi
Copy link
Member

danmuzi commented Jun 11, 2020

Please do the "Squash and merge" below.
Your sub commits will be combined automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants