LUCENE-9356: Add a test that verifies that Lucene catches bit flips. #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
force-pushed
the
bit_flip_detection
branch
from
b0cf009
to
e231f66
Compare
msokolov
approved these changes
Jun 11, 2020
| try (IndexInput in = dirCopy.openInput(name, IOContext.DEFAULT)) { | ||
| try { | ||
| CodecUtil.checksumEntireFile(in); | ||
| System.out.println("TEST: changing a byte in " + victim + " did not update the checksum)"); |
There was a problem hiding this comment.
curious if you saw this much?
There was a problem hiding this comment.
I haven't seen a single occurrence of it (fortunately! :) )
We only verify checksums of meta file when opening (those that we read entirely anyway). Checksums only get verified on other files when |
mikemccand
approved these changes
Jun 11, 2020
| } | ||
|
|
||
| RandomIndexWriter riw = new RandomIndexWriter(random(), dir, conf); | ||
| // Use LineFileDocs so we (hopefully) get most Lucene features |
There was a problem hiding this comment.
This is actually copy-pasted from TestAllFilesDetectTruncation :)
| private void checkBitFlips(Directory dir) throws IOException { | ||
| for(String name : dir.listAll()) { | ||
| if (name.equals(IndexWriter.WRITE_LOCK_NAME) == false) { | ||
| corruptFile(dir, name); |
There was a problem hiding this comment.
Do you maybe need to exclude extraN files for when ExtraFS randomly strikes?
Edit: oh, nevermind, I see we suppress ExtraFS above :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a reader and then calling checkIntegrity must throw a
CorruptIndexExceptionor anIndexFormatToo(Old|New)Exception.